Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: src/trusted/validator_arm/actual_vs_baseline.cc

Issue 12095039: Add testing of generated (ARM) baseline decoders using hand-written decoders. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator_arm/actual_vs_baseline.cc
===================================================================
--- src/trusted/validator_arm/actual_vs_baseline.cc (revision 10678)
+++ src/trusted/validator_arm/actual_vs_baseline.cc (working copy)
@@ -24,6 +24,11 @@
actual_decoder_(actual_.named_decoder()),
baseline_decoder_(baseline_.named_decoder()) {}
+bool ActualVsBaselineTester::DoApplySanityChecks() {
+ return baseline_tester_.ApplySanityChecks(
+ inst_, baseline_tester_.GetInstDecoder());
+}
+
void ActualVsBaselineTester::ProcessMatch() {
baseline_tester_.InjectInstruction(inst_);
const NamedClassDecoder& decoder = baseline_tester_.GetInstDecoder();
@@ -36,7 +41,7 @@
if (nacl_arm_dec::MAY_BE_SAFE == decoder.safety(inst_)) {
// Run sanity baseline checks, to see that the baseline is
// correct.
- if (!baseline_tester_.ApplySanityChecks(inst_, decoder)) {
+ if (!DoApplySanityChecks()) {
// The sanity checks found a serious issue and already reported
// it. don't bother to report additional problems.
return;

Powered by Google App Engine
This is Rietveld 408576698