Add testing of generated (ARM) baseline decoders using hand-written decoders.

src/trusted/validator_arm/actual_vs_baseline.cc

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef NACL_TRUSTED_BUT_NOT_TCB
 #error This file is not meant for use in the TCB
 #endif
 
 #include "native_client/src/trusted/validator_arm/actual_vs_baseline.h"
 
 #include "gtest/gtest.h"
 
 namespace nacl_arm_test {
 
 ActualVsBaselineTester::ActualVsBaselineTester(
     const NamedClassDecoder& actual,
     DecoderTester& baseline_tester)
     : Arm32DecoderTester(baseline_tester.ExpectedDecoder()),
       actual_(actual),
       baseline_(baseline_tester.ExpectedDecoder()),
       baseline_tester_(baseline_tester),
       actual_decoder_(actual_.named_decoder()),
       baseline_decoder_(baseline_.named_decoder()) {}
 
+bool ActualVsBaselineTester::DoApplySanityChecks() {
+  return baseline_tester_.ApplySanityChecks(
+      inst_, baseline_tester_.GetInstDecoder());
+}
+
 void ActualVsBaselineTester::ProcessMatch() {
   baseline_tester_.InjectInstruction(inst_);
   const NamedClassDecoder& decoder = baseline_tester_.GetInstDecoder();
   if (!baseline_tester_.PassesParsePreconditions(inst_, decoder)) {
     // Parse precondition implies that this pattern is NOT supposed to
     // be handled by the baseline tester (because another decoder
     // handles it). Hence, don't do any further processing.
     return;
   }
   if (nacl_arm_dec::MAY_BE_SAFE == decoder.safety(inst_)) {
     // Run sanity baseline checks, to see that the baseline is
     // correct.
-    if (!baseline_tester_.ApplySanityChecks(inst_, decoder)) {
+    if (!DoApplySanityChecks()) {
       // The sanity checks found a serious issue and already reported
       // it.  don't bother to report additional problems.
       return;
     }
     // Check virtuals. Start with check if safe. If unsafe, no further
     // checking need be applied, since the validator will stop
     // processing such instructions after the safe test.
     if (!MayBeSafe()) return;
   } else {
     // Not safe in baseline, only compare safety, testing if not safe
@@ skipping 135 matching lines @@
   // Note: We don't actually test all combinations of masks. We just
   // try a few.
   for (uint32_t i = 0; i < 15; ++i) {
     nacl_arm_dec::Register r(i);
     EXPECT_EQ(baseline_decoder_.sets_Z_if_bits_clear(inst_, r, data24_mask),
               actual_decoder_.sets_Z_if_bits_clear(inst_, r, data24_mask));
   }
 }
 
 }  // namespace nacl_arm_test