Make gcl commit/git cl dcommit append a commit notification to rietveld.

Make gcl commit/git cl dcommit append a commit notification to rietveld.

R=maruel@chromium.org
BUG=163426
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=178975

[iannucci, 2013-01-24 20:05:25]

PTAL

[iannucci, 2013-01-25 00:20:52]

On 2013/01/24 20:05:25, iannucci wrote:
> PTAL

Actually hold off on the review. ilevy@ suggested that I also include text which
indicates if --bypass-hooks was used, but I have to run now.

[iannucci, 2013-01-25 21:48:29]

On 2013/01/25 00:20:52, iannucci wrote:
> On 2013/01/24 20:05:25, iannucci wrote:
> > PTAL
> 
> Actually hold off on the review. ilevy@ suggested that I also include text
which
> indicates if --bypass-hooks was used, but I have to run now.

PTAL now :).  The message will now say:

Committed manually as r12345 (presubmit successful).

or

Committed manually as r12345.

[Isaac (away), 2013-01-25 21:50:30]

sgtm.  Drover reverts don't do presubmit so the mild language is advantageous
there.

[M-A Ruel, 2013-01-25 23:28:43]

lgtm

https://chromiumcodereview.appspot.com/12047089/diff/4001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/12047089/diff/4001/git_cl.py#newcode615
git_cl.py:615: def AddComment(self, comment):
This method doesn't add much, you can as well just call it directly.

[iannucci, 2013-01-25 23:33:00]

https://chromiumcodereview.appspot.com/12047089/diff/4001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/12047089/diff/4001/git_cl.py#newcode615
git_cl.py:615: def AddComment(self, comment):
On 2013/01/25 23:28:43, Marc-Antoine Ruel wrote:
> This method doesn't add much, you can as well just call it directly.

Ok, sgtm. I wasn't sure about consistency/style. Same for gcl, I assume?

[M-A Ruel, 2013-01-25 23:47:10]

https://chromiumcodereview.appspot.com/12047089/diff/4001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/12047089/diff/4001/git_cl.py#newcode615
git_cl.py:615: def AddComment(self, comment):
On 2013/01/25 23:33:00, iannucci wrote:
> On 2013/01/25 23:28:43, Marc-Antoine Ruel wrote:
> > This method doesn't add much, you can as well just call it directly.
> 
> Ok, sgtm. I wasn't sure about consistency/style. Same for gcl, I assume?

gcl and git_cl.py are completely separate, no need to copy "style" between them.

[commit-bot: I haz the power, 2013-01-26 01:08:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/12047089/9001

[commit-bot: I haz the power, 2013-01-26 01:11:15]

Change committed as 178975

[jam, 2013-02-20 18:15:55]

hmm, I think the extra message being added is redundant. i understood from the
chromium-dev thread that the cl desc would get the patchset number and whether
presubmit passed or not, but i thought that this also wouldn't get posted as a
comment here.