Make gcl commit/git cl dcommit append a commit notification to rietveld.

gcl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """\
 Wrapper script around Rietveld's upload.py that simplifies working with groups
 of files.
 """
 
@@ skipping 375 matching lines @@
     """Sets the description for an issue on Rietveld."""
     data = [("description", self.description),]
     ctype, body = upload.EncodeMultipartFormData(data, [])
     self.SendToRietveld('/%d/description' % self.issue, payload=body,
         content_type=ctype)
 
   def GetIssueDescription(self):
     """Returns the issue description from Rietveld."""
     return self.SendToRietveld('/%d/description' % self.issue)
 
+  def AddComment(self, comment):
+    """Adds a comment for an issue on Rietveld.
+    As a side effect, this will email everyone associated with the issue."""
+    return self.RpcServer().add_comment(self.issue, comment)
+
   def PrimeLint(self):
     """Do background work on Rietveld to lint the file so that the results are
     ready when the issue is viewed."""
     if self.issue and self.patchset:
       self.SendToRietveld('/lint/issue%s_%s' % (self.issue, self.patchset),
           timeout=10)
 
   def SendToRietveld(self, request_path, timeout=None, **kwargs):
     """Send a POST/GET to Rietveld.  Returns the response body."""
     try:
@@ skipping 569 matching lines @@
 
 
 @need_change_and_args
 @attrs(usage='[--no_presubmit]')
 def CMDcommit(change_info, args):
   """Commits the changelist to the repository."""
   if not change_info.GetFiles():
     print "Nothing to commit, changelist is empty."
     return 1
 
+  # OptionallyDoPresubmitChecks has a side-effect which eats these flags.
+  bypassed = '--no_presubmit' in args or '--force' in args
   output = OptionallyDoPresubmitChecks(change_info, True, args)
   if not output.should_continue():
     return 1
 
   # We face a problem with svn here: Let's say change 'bleh' modifies
   # svn:ignore on dir1\. but another unrelated change 'pouet' modifies
   # dir1\foo.cc. When the user `gcl commit bleh`, foo.cc is *also committed*.
   # The only fix is to use --non-recursive but that has its issues too:
   # Let's say if dir1 is deleted, --non-recursive must *not* be used otherwise
   # you'll get "svn: Cannot non-recursively commit a directory deletion of a
@@ skipping 36 matching lines @@
     if change_info.issue:
       revision = re.compile(".*?\nCommitted revision (\d+)",
                             re.DOTALL).match(output).group(1)
       viewvc_url = GetCodeReviewSetting('VIEW_VC')
       change_info.description += '\n'
       if viewvc_url and revision:
         change_info.description += "\nCommitted: " + viewvc_url + revision
       elif revision:
         change_info.description += "\nCommitted: " + revision
       change_info.CloseIssue()
+      comment = "Committed manually as r%s" % revision
+      comment += ' (presubmit successful).' if not bypassed else '.'
+      change_info.AddComment(comment)
   return 0
 
 
 def CMDchange(args):
   """Creates or edits a changelist.
 
   Only scans the current directory and subdirectories.
   """
   # Verify the user is running the change command from a read-write checkout.
   svn_info = SVN.CaptureLocalInfo([], '.')
@@ skipping 406 matching lines @@
       raise
     print >> sys.stderr, (
         'AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
         'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))
     return 1
 
 
 if __name__ == "__main__":
   fix_encoding.fix_encoding()
   sys.exit(main(sys.argv[1:]))