Make gcl commit/git cl dcommit append a commit notification to rietveld.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 import json
@@ skipping 594 matching lines @@
           else:
             DieWithError(
                 '\nFailed to fetch issue description. HTTP error ' + e.code)
       self.has_description = True
     if pretty:
       wrapper = textwrap.TextWrapper()
       wrapper.initial_indent = wrapper.subsequent_indent = '  '
       return wrapper.fill(self.description)
     return self.description
 
+  def AddComment(self, comment):

[M-A Ruel, 2013/01/25 23:28:43]

This method doesn't add much, you can as well just call it directly.

[iannucci, 2013/01/25 23:33:00]

Ok, sgtm. I wasn't sure about consistency/style. Same for gcl, I assume?

[M-A Ruel, 2013/01/25 23:47:10]

gcl and git_cl.py are completely separate, no need to copy "style" between them.

+    """Adds a comment for an issue on Rietveld.
+    As a side effect, this will email everyone associated with the issue."""
+    return self.RpcServer().add_comment(self.GetIssue(), comment)
+
   def GetPatchset(self):
     """Returns the patchset number as a int or None if not set."""
     if not self.has_patchset:
       patchset = RunGit(['config', self._PatchsetSetting()],
                         error_ok=True).strip()
       if patchset:
         self.patchset = int(patchset)
       else:
         self.patchset = None
       self.has_patchset = True
@@ skipping 863 matching lines @@
     else:
       return 1
     viewvc_url = settings.GetViewVCUrl()
     if viewvc_url and revision:
       cl.description += ('\n\nCommitted: ' + viewvc_url + revision)
     elif revision:
       cl.description += ('\n\nCommitted: ' + revision)
     print ('Closing issue '
            '(you may be prompted for your codereview password)...')
     cl.CloseIssue()
+    comment = "Committed manually as r%s" % revision
+    comment += ' (presubmit successful).' if not options.bypass_hooks else '.'
+    cl.AddComment(comment)
     cl.SetIssue(0)
 
   if retcode == 0:
     hook = POSTUPSTREAM_HOOK_PATTERN % cmd
     if os.path.isfile(hook):
       RunCommand([hook, base_branch], error_ok=True)
 
   return 0
 
 
@@ skipping 358 matching lines @@
              'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
   # Not a known command. Default to help.
   GenUsage(parser, 'help')
   return CMDhelp(parser, argv)
 
 
 if __name__ == '__main__':
   fix_encoding.fix_encoding()
   sys.exit(main(sys.argv[1:]))