Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 12022043: cc: Fix inappropriate use of term "texture". (Closed)

Created:
7 years, 11 months ago by reveman
Modified:
7 years, 11 months ago
Reviewers:
nduca, brianderson
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Fix inappropriate use of term "texture". Avoid using the term "texture" when referring to a resource object that can be either software bitmap or a hardware texture. This also fixes some minor spelling mistakes. BUG=169603 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178172

Patch Set 1 #

Patch Set 2 : s/InitializeTile/UploadTile/ and s/CompletedSetPixels/CompletedTileUploads/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -68 lines) Patch
M cc/layer_tree_host_impl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_tree_host_impl.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M cc/scheduler.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/scheduler.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M cc/scheduler_state_machine.h View 1 4 chunks +7 lines, -7 lines 0 comments Download
M cc/scheduler_state_machine.cc View 1 11 chunks +22 lines, -22 lines 0 comments Download
M cc/scheduler_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/single_thread_proxy.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/single_thread_proxy.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/thread_proxy.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/thread_proxy.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M cc/tile_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/tile_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reveman
There's still a bunch of places where we inappropriately use the term "texture" when referring ...
7 years, 11 months ago (2013-01-19 17:20:27 UTC) #1
nduca
I get the texture changes. But upload makes sense to me.
7 years, 11 months ago (2013-01-22 21:33:21 UTC) #2
reveman
On 2013/01/22 21:33:21, nduca wrote: > I get the texture changes. But upload makes sense ...
7 years, 11 months ago (2013-01-22 23:23:16 UTC) #3
nduca
lgtm
7 years, 11 months ago (2013-01-22 23:44:23 UTC) #4
brianderson
lgtm too. Thanks for fixing the naming David. I'll be more careful about my use ...
7 years, 11 months ago (2013-01-22 23:56:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/12022043/4001
7 years, 11 months ago (2013-01-23 00:07:46 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-23 00:21:15 UTC) #7
Message was sent while issue was closed.
Change committed as 178172

Powered by Google App Engine
This is Rietveld 408576698