Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: tests/gdb/gdb_test.py

Issue 11896007: GDB: Test for executing nacl-manifest command twice. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/gdb/gdb_test.py
===================================================================
--- tests/gdb/gdb_test.py (revision 10609)
+++ tests/gdb/gdb_test.py (working copy)
@@ -247,17 +247,21 @@
def Eval(self, expression):
return self.Command('-data-evaluate-expression ' + expression)['value']
+ def LoadManifestFile(self):
+ assert self._manifest_file is not None
+ self.Command('nacl-manifest ' + self._manifest_file)
Mark Seaborn 2013/01/21 15:52:35 Why no FilenameToUnix() here?
halyavin 2013/01/22 08:04:27 Done.
+
def Connect(self):
self._GetResponse()
if self._options.irt is not None:
self.Command('nacl-irt ' + FilenameToUnix(self._options.irt))
if self._options.ld_so is not None:
# gdb uses bash-like escaping which removes slashes from Windows paths.
- manifest_file = GenerateManifest(self._options.output_dir,
- self._options.nexe,
- self._options.ld_so,
- self._name)
- self.Command('nacl-manifest ' + FilenameToUnix(manifest_file))
+ self._manifest_file = GenerateManifest(self._options.output_dir,
+ self._options.nexe,
+ self._options.ld_so,
+ self._name)
+ self.Command('nacl-manifest ' + FilenameToUnix(self._manifest_file))
Mark Seaborn 2013/01/21 15:52:35 Call LoadManifestFile() here?
halyavin 2013/01/22 08:04:27 Done.
self.Command('set breakpoint pending on')
else:
self.Command('file ' + FilenameToUnix(self._options.nexe))

Powered by Google App Engine
This is Rietveld 408576698