Issue 11896007: GDB: Test for executing nacl-manifest command twice.

Issue 11896007: GDB: Test for executing nacl-manifest command twice. (Closed)

Created:
7 years, 11 months ago by halyavin

Modified:
7 years, 11 months ago

Reviewers:
Mark Seaborn

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

More Reviews

Description

GDB: Test for executing nacl-manifest command twice. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3262 TEST= run_gdb_execute_nacl_manifest_twice_test Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10653

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -6 lines)			Patch
A	tests/gdb/execute_nacl_manifest_twice.py	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	tests/gdb/gdb_test.py	View	1	1 chunk	+10 lines, -6 lines	0 comments	Download
M	tests/gdb/nacl.scons	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

LGTM https://chromiumcodereview.appspot.com/11896007/diff/1/tests/gdb/execute_nacl_manifest_twice.py File tests/gdb/execute_nacl_manifest_twice.py (right): https://chromiumcodereview.appspot.com/11896007/diff/1/tests/gdb/execute_nacl_manifest_twice.py#newcode11 tests/gdb/execute_nacl_manifest_twice.py:11: gdb.LoadManifestFile() Maybe comment that this is a second, ...

7 years, 11 months ago (2013-01-21 15:52:35 UTC) #2

halyavin

7 years, 11 months ago (2013-01-22 08:04:27 UTC) #3

https://chromiumcodereview.appspot.com/11896007/diff/1/tests/gdb/execute_nacl...
File tests/gdb/execute_nacl_manifest_twice.py (right):

https://chromiumcodereview.appspot.com/11896007/diff/1/tests/gdb/execute_nacl...
tests/gdb/execute_nacl_manifest_twice.py:11: gdb.LoadManifestFile()
On 2013/01/21 15:52:35, Mark Seaborn wrote:
> Maybe comment that this is a second, superfluous call to LoadManifestFile(),
and
> that this is a regression test for a particular crash bug.

Done.

https://chromiumcodereview.appspot.com/11896007/diff/1/tests/gdb/gdb_test.py
File tests/gdb/gdb_test.py (right):

https://chromiumcodereview.appspot.com/11896007/diff/1/tests/gdb/gdb_test.py#...
tests/gdb/gdb_test.py:252: self.Command('nacl-manifest ' + self._manifest_file)
On 2013/01/21 15:52:35, Mark Seaborn wrote:
> Why no FilenameToUnix() here?

Done.

https://chromiumcodereview.appspot.com/11896007/diff/1/tests/gdb/gdb_test.py#...
tests/gdb/gdb_test.py:264: self.Command('nacl-manifest ' +
FilenameToUnix(self._manifest_file))
On 2013/01/21 15:52:35, Mark Seaborn wrote:
> Call LoadManifestFile() here?

Done.

Expand Messages | Collapse Messages