GDB: Test for executing nacl-manifest command twice.

tests/gdb/gdb_test.py

 # -*- python -*-
 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import optparse
 import os
 import re
 import socket
@@ skipping 229 matching lines @@
           'GDB reported stop reason %r but we expected %r (full info is %r)'
           % (stop_info.get('reason'), expected_stop_reason, stop_info))
 
   def Quit(self):
     status, items = self._GetResultRecord(self._SendRequest('-gdb-exit'))
     AssertEquals(status, '^exit')
 
   def Eval(self, expression):
     return self.Command('-data-evaluate-expression ' + expression)['value']
 
+  def LoadManifestFile(self):
+    assert self._manifest_file is not None
+    self.Command('nacl-manifest ' + self._manifest_file)

[Mark Seaborn, 2013/01/21 15:52:35]

Why no FilenameToUnix() here?

[halyavin, 2013/01/22 08:04:27]

Done.

+
   def Connect(self):
     self._GetResponse()
     if self._options.irt is not None:
       self.Command('nacl-irt ' + FilenameToUnix(self._options.irt))
     if self._options.ld_so is not None:
       # gdb uses bash-like escaping which removes slashes from Windows paths.
-      manifest_file = GenerateManifest(self._options.output_dir,
-                                       self._options.nexe,
-                                       self._options.ld_so,
-                                       self._name)
-      self.Command('nacl-manifest ' + FilenameToUnix(manifest_file))
+      self._manifest_file = GenerateManifest(self._options.output_dir,
+                                             self._options.nexe,
+                                             self._options.ld_so,
+                                             self._name)
+      self.Command('nacl-manifest ' + FilenameToUnix(self._manifest_file))

[Mark Seaborn, 2013/01/21 15:52:35]

Call LoadManifestFile() here?

[halyavin, 2013/01/22 08:04:27]

Done.

       self.Command('set breakpoint pending on')
     else:
       self.Command('file ' + FilenameToUnix(self._options.nexe))
     self.Command('target remote :4014')
 
 
 def RunTest(test_func, test_name):
   parser = optparse.OptionParser()
   parser.add_option('--output_dir', help='Output directory for log files')
   parser.add_option('--gdb', help='Filename of GDB')
   parser.add_option('--irt', help='Filename of irt.nexe (optional)')
   parser.add_option('--ld_so', help='Filename of dynamic linker (optional)')
   parser.add_option('--library_path',
                     help='Directory containing dynamic libraries, '
                     'if using dynamic linking (optional)')
   parser.add_option('--nexe', help='Filename of main NaCl executable')
   options, sel_ldr_command = parser.parse_args()
 
   sel_ldr = LaunchSelLdr(sel_ldr_command, options, test_name)
   try:
     with Gdb(options, test_name) as gdb:
       gdb.Connect()
       test_func(gdb)
   finally:
     KillProcess(sel_ldr)