Partially comment IsCheckable implementation in renderer

Partially comment IsCheckable implementation in renderer

BUG=170064
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176994

[Raman Kakilate, 2013-01-15 16:09:28]

I have commented part of IsCheckableElement as against the initial plan I mailed
you: to comment out IsCheckableElement in its entirety. Problem with that plan
is that extra IsSelectElement is only called during filling form element.

[Albert Bodenhamer, 2013-01-15 17:50:48]

I'm not able to get the diff to come up.  Looks like an issue with the
patch.  Can you merge and upload another patch?


On Tue, Jan 15, 2013 at 8:09 AM, <ramankk@chromium.org> wrote:

> Reviewers: Ilya Sherman, Albert Bodenhamer,
>
> Message:
> I have commented part of IsCheckableElement as against the initial plan I
> mailed
> you: to comment out IsCheckableElement in its entirety. Problem with that
> plan
> is that extra IsSelectElement is only called during filling form element.
>
> Description:
> Partially comment IsCheckable implementation in renderer
>
> BUG=170064
>
>
> Please review this at
https://codereview.chromium.**org/11883036/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   chrome/renderer/autofill/form_**autofill_util.cc
>
>
> Index: chrome/renderer/autofill/form_**autofill_util.cc
> diff --git a/chrome/renderer/autofill/**form_autofill_util.cc
> b/chrome/renderer/autofill/**form_autofill_util.cc
> index 3a91746ca6512f74f90511b088d945**e7029fc25a..**
> bd3b651ccb23aee7eb72605140bf52**7c783607ce 100644
> --- a/chrome/renderer/autofill/**form_autofill_util.cc
> +++ b/chrome/renderer/autofill/**form_autofill_util.cc
> @@ -582,7 +582,8 @@ bool IsCheckableElement(const WebInputElement*
> element) {
>      return false;
>
>    WebString formControlType = element->formControlType();
> -  return formControlType == kCheckbox || formControlType == kRadio;
> +  // TODO(ramankk): Uncomment kRadio part after testing for regression.
> +  return formControlType == kCheckbox; // || formControlType == kRadio;
>  }
>
>  bool IsAutofillableInputElement(**const WebInputElement* element) {
>
>
>


-- 
Albert Bodenhamer | Software Engineer | abodenha@chromium.<abodenha@google.com>
org

[Albert Bodenhamer, 2013-01-15 18:05:18]

lgtm

[Albert Bodenhamer, 2013-01-15 18:05:44]

lgtm

[dhollowa, 2013-01-15 18:11:27]

Rubber stamp LGTM.

[commit-bot: I haz the power, 2013-01-15 18:14:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ramankk@chromium.org/11883036/6001

[commit-bot: I haz the power, 2013-01-15 18:17:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ramankk@chromium.org/11883036/6001

[commit-bot: I haz the power, 2013-01-15 19:02:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ramankk@chromium.org/11883036/6001

[commit-bot: I haz the power, 2013-01-15 19:23:12]

Retried try job too often on linux_aura for step(s) aura_unittests,
compositor_unittests, content_browsertests, content_unittests,
interactive_ui_tests, unit_tests, views_unittests

[Raman Kakilate, 2013-01-15 19:49:33]

My bad. Missed updating the test. PTAL.

[Albert Bodenhamer, 2013-01-15 19:50:46]

still LGTM


On Tue, Jan 15, 2013 at 11:49 AM, <ramankk@chromium.org> wrote:

> My bad. Missed updating the test. PTAL.
>
>
https://codereview.chromium.**org/11883036/<https://codereview.chromium.org/1...
>



-- 
Albert Bodenhamer | Software Engineer | abodenha@chromium.<abodenha@google.com>
org

[commit-bot: I haz the power, 2013-01-15 20:27:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ramankk@chromium.org/11883036/23001

[commit-bot: I haz the power, 2013-01-15 22:33:39]

Change committed as 176994