Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: chrome/renderer/autofill/form_autofill_util.cc

Issue 11883036: Partially comment IsCheckable implementation in renderer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment radio button test as well. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/autofill/form_autofill_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/autofill/form_autofill_util.cc
diff --git a/chrome/renderer/autofill/form_autofill_util.cc b/chrome/renderer/autofill/form_autofill_util.cc
index 3a91746ca6512f74f90511b088d945e7029fc25a..e812cbf4d17408d1477ae666fbf8154e29e6d169 100644
--- a/chrome/renderer/autofill/form_autofill_util.cc
+++ b/chrome/renderer/autofill/form_autofill_util.cc
@@ -575,14 +575,16 @@ bool IsSelectElement(const WebFormControlElement& element) {
bool IsCheckableElement(const WebInputElement* element) {
// Is static for improving performance.
- CR_DEFINE_STATIC_LOCAL(WebString, kRadio, ("radio"));
+ // TODO(ramankk): Uncomment kRadio part after testing for regression.
+ // CR_DEFINE_STATIC_LOCAL(WebString, kRadio, ("radio"));
CR_DEFINE_STATIC_LOCAL(WebString, kCheckbox, ("checkbox"));
if (!element)
return false;
WebString formControlType = element->formControlType();
- return formControlType == kCheckbox || formControlType == kRadio;
+ // TODO(ramankk): Uncomment kRadio part after testing for regression.
+ return formControlType == kCheckbox; // || formControlType == kRadio;
}
bool IsAutofillableInputElement(const WebInputElement* element) {
« no previous file with comments | « chrome/renderer/autofill/form_autofill_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698