Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8722)

Unified Diff: chrome/renderer/autofill/form_autofill_browsertest.cc

Issue 11883036: Partially comment IsCheckable implementation in renderer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment radio button test as well. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/autofill/form_autofill_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/autofill/form_autofill_browsertest.cc
diff --git a/chrome/renderer/autofill/form_autofill_browsertest.cc b/chrome/renderer/autofill/form_autofill_browsertest.cc
index 7455dfd06cf08da0b10ed202a3dbb1661eab96db..f391b7d440809d25624dc6aea4fb7a5197af37d7 100644
--- a/chrome/renderer/autofill/form_autofill_browsertest.cc
+++ b/chrome/renderer/autofill/form_autofill_browsertest.cc
@@ -237,7 +237,8 @@ TEST_F(FormAutofillTest, WebFormControlElementToClickableFormField) {
expected.is_checkable = true;
EXPECT_FORM_FIELD_DATA_EQUALS(expected, result);
- web_element = frame->document().getElementById("radio");
+ // TODO(ramankk): Uncomment after testing the regression, crbug/170064.
+ /* web_element = frame->document().getElementById("radio");
element = web_element.to<WebInputElement>();
element.setAutofilled(true);
WebFormControlElementToFormField(element, autofill::EXTRACT_VALUE, &result);
@@ -246,7 +247,7 @@ TEST_F(FormAutofillTest, WebFormControlElementToClickableFormField) {
expected.form_control_type = "radio";
expected.is_autofilled = true;
expected.is_checkable = true;
- EXPECT_FORM_FIELD_DATA_EQUALS(expected, result);
+ EXPECT_FORM_FIELD_DATA_EQUALS(expected, result); */
}
// We should be able to extract a <select> field.
« no previous file with comments | « no previous file | chrome/renderer/autofill/form_autofill_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698