Issue 11867016: handle OWNERS suggestions where anyone can approve better.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11867016: handle OWNERS suggestions where anyone can approve better. (Closed)

Created:
7 years, 11 months ago by Dirk Pranke

Modified:
7 years, 11 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

handle OWNERS suggestions where anyone can approve better. previously we would return "*" as one of the suggested owners when a CL included a file that anyone could approve. If the change had other owners, the "*" was unnecessary, and if the change only included wildcard-owned files, "*" isn't very helpful, so I've changed the text slightly. R=maruel@chromium.org BUG=169168 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=177575

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	owners.py	View		1 chunk	+7 lines, -1 line	0 comments	Download
	M	tests/owners_unittest.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/11867016/1

7 years, 11 months ago (2013-01-18 02:50:46 UTC) #3

commit-bot: I haz the power

Commit queue rejected this change because the description was changed between the time the change ...

7 years, 11 months ago (2013-01-18 02:53:38 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/11867016/1

7 years, 11 months ago (2013-01-18 02:54:40 UTC) #5

Message was sent while issue was closed.

Change committed as 177575

Expand Messages | Collapse Messages