Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: tests/owners_unittest.py

Issue 11867016: handle OWNERS suggestions where anyone can approve better. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « owners.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Unit tests for owners.py.""" 6 """Unit tests for owners.py."""
7 7
8 import os 8 import os
9 import sys 9 import sys
10 import unittest 10 import unittest
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 self.assertRaises(AssertionError, db.reviewers_for, 'foo') 252 self.assertRaises(AssertionError, db.reviewers_for, 'foo')
253 if hasattr(owners.collections, 'Iterable'): 253 if hasattr(owners.collections, 'Iterable'):
254 self.assertRaises(AssertionError, db.reviewers_for, 254 self.assertRaises(AssertionError, db.reviewers_for,
255 (f for f in ['x', 'y'])) 255 (f for f in ['x', 'y']))
256 256
257 # Check that the files are under the root. 257 # Check that the files are under the root.
258 db.root = '/checkout' 258 db.root = '/checkout'
259 self.assertRaises(AssertionError, db.reviewers_for, ['/OWNERS']) 259 self.assertRaises(AssertionError, db.reviewers_for, ['/OWNERS'])
260 260
261 def test_reviewers_for__wildcard_dir(self): 261 def test_reviewers_for__wildcard_dir(self):
262 self.assert_reviewers_for(['DEPS'], [owners.EVERYONE]) 262 self.assert_reviewers_for(['DEPS'], ['<anyone>'])
263 self.assert_reviewers_for(['DEPS', 'chrome/gpu/gpu_channel.h'], [ken])
263 264
264 def test_reviewers_for__one_owner(self): 265 def test_reviewers_for__one_owner(self):
265 self.assert_reviewers_for([ 266 self.assert_reviewers_for([
266 'chrome/gpu/gpu_channel.h', 267 'chrome/gpu/gpu_channel.h',
267 'content/baz/froboz.h', 268 'content/baz/froboz.h',
268 'chrome/renderer/gpu/gpu_channel_host.h'], 269 'chrome/renderer/gpu/gpu_channel_host.h'],
269 [brett]) 270 [brett])
270 271
271 def test_reviewers_for__two_owners(self): 272 def test_reviewers_for__two_owners(self):
272 self.assert_reviewers_for([ 273 self.assert_reviewers_for([
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 ('chrome/browser', 2)], 386 ('chrome/browser', 2)],
386 ken: [('chrome/gpu', 1)], 387 ken: [('chrome/gpu', 1)],
387 peter: [('chrome/renderer', 1)], 388 peter: [('chrome/renderer', 1)],
388 brett: [('chrome/browser', 1)]}, 389 brett: [('chrome/browser', 1)]},
389 ['chrome/gpu', 'chrome/renderer', 390 ['chrome/gpu', 'chrome/renderer',
390 'chrome/browser'], 391 'chrome/browser'],
391 ben) 392 ben)
392 393
393 if __name__ == '__main__': 394 if __name__ == '__main__':
394 unittest.main() 395 unittest.main()
OLDNEW
« no previous file with comments | « owners.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698