Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests/owners_unittest.py

Issue 11867016: handle OWNERS suggestions where anyone can approve better. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « owners.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/owners_unittest.py
diff --git a/tests/owners_unittest.py b/tests/owners_unittest.py
index 552fa78dcef0633bb23430ec404ec45f72308fe6..20491ab4d460155282939db584224c851cf3c2c8 100755
--- a/tests/owners_unittest.py
+++ b/tests/owners_unittest.py
@@ -259,7 +259,8 @@ class ReviewersForTest(_BaseTestCase):
self.assertRaises(AssertionError, db.reviewers_for, ['/OWNERS'])
def test_reviewers_for__wildcard_dir(self):
- self.assert_reviewers_for(['DEPS'], [owners.EVERYONE])
+ self.assert_reviewers_for(['DEPS'], ['<anyone>'])
+ self.assert_reviewers_for(['DEPS', 'chrome/gpu/gpu_channel.h'], [ken])
def test_reviewers_for__one_owner(self):
self.assert_reviewers_for([
« no previous file with comments | « owners.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698