Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1181893003: Kill bad apps. (Closed)

Created:
5 years, 6 months ago by EhsanK
Modified:
5 years, 5 months ago
Reviewers:
Fady Samuel, Devlin, lazyboy, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

There were two TODO(fsamuel)'s were the guest app must have been killed. This is handled by passing the app's RenderProcessHost ID as the last argument to "extensions::AppViewGuest::CompletePendingRequest". Two tests are implemented. Committed: https://crrev.com/725a6cae963a44de80afec2e3cd9d597fecf7b7d Cr-Commit-Position: refs/heads/master@{#337692}

Patch Set 1 #

Total comments: 31

Patch Set 2 : Hacky Solution for a Test. #

Patch Set 3 : Added a Missing File #

Total comments: 4

Patch Set 4 : Fixed Tests. #

Patch Set 5 : Used the API in "extensions/bad_message.h" to Kill and Report Bad Guests. #

Total comments: 22

Patch Set 6 : Refactoring and Reformatting #

Patch Set 7 : Removed Unnecessary Included File. #

Total comments: 19

Patch Set 8 : Fixed More Formatting Problems. #

Patch Set 9 : Removed Check for Termination Status (Windows Problems) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -22 lines) Patch
M chrome/browser/apps/guest_view/app_view_browsertest.cc View 1 2 3 4 5 6 7 8 5 chunks +126 lines, -2 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/app_view/bad_app/background.js View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
A + chrome/test/data/extensions/platform_apps/app_view/bad_app/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/app_view/bad_app/window.html View 1 2 3 4 5 1 chunk +5 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/app_view/guest_app/background.js View 1 2 3 4 5 6 7 1 chunk +27 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/app_view/guest_app/manifest.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/app_view/guest_app/window.html View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/app_view/host_app/background.js View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
A chrome/test/data/extensions/platform_apps/app_view/host_app/manifest.json View 1 chunk +10 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/app_view/host_app/window.html View 1 2 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/app_view/host_app/window.js View 1 2 3 4 5 6 7 1 chunk +17 lines, -0 lines 0 comments Download
M extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc View 1 2 3 4 5 6 7 3 chunks +5 lines, -2 lines 0 comments Download
M extensions/browser/bad_message.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/app_view/app_view_guest.h View 1 2 3 4 5 6 7 1 chunk +12 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/app_view/app_view_guest.cc View 1 2 3 4 5 6 7 8 3 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 38 (12 generated)
EhsanK
PTAL. I was not sure if I am on the right track so I decided ...
5 years, 6 months ago (2015-06-12 18:53:34 UTC) #2
lfg
Added some comments. https://codereview.chromium.org/1181893003/diff/1/chrome/browser/apps/guest_view/app_view_browsertest.cc File chrome/browser/apps/guest_view/app_view_browsertest.cc (right): https://codereview.chromium.org/1181893003/diff/1/chrome/browser/apps/guest_view/app_view_browsertest.cc#newcode51 chrome/browser/apps/guest_view/app_view_browsertest.cc:51: void RenderProcessHostDestroyed(content::RenderProcessHost* host) override { Use ...
5 years, 6 months ago (2015-06-12 21:43:47 UTC) #3
EhsanK
PTAL. There are three tests now. The first one works like before. The second one ...
5 years, 6 months ago (2015-06-25 16:19:51 UTC) #4
lfg
Overall it's looking good, but we need to figure out what are the issues with ...
5 years, 6 months ago (2015-06-26 21:46:06 UTC) #5
lazyboy
Only looked at the test file to see what's going on there... https://chromiumcodereview.appspot.com/1181893003/diff/40001/chrome/browser/apps/guest_view/app_view_browsertest.cc File chrome/browser/apps/guest_view/app_view_browsertest.cc ...
5 years, 5 months ago (2015-06-29 20:05:34 UTC) #6
EhsanK
PTAL. https://codereview.chromium.org/1181893003/diff/1/chrome/browser/apps/guest_view/app_view_browsertest.cc File chrome/browser/apps/guest_view/app_view_browsertest.cc (right): https://codereview.chromium.org/1181893003/diff/1/chrome/browser/apps/guest_view/app_view_browsertest.cc#newcode53 chrome/browser/apps/guest_view/app_view_browsertest.cc:53: host->RemoveObserver(this); On 2015/06/12 21:43:46, lfg wrote: > The ...
5 years, 5 months ago (2015-06-30 16:53:11 UTC) #7
EhsanK
asvitkine@chromium.org: Please review changes in PTAL at the newly added metric. Thanks.
5 years, 5 months ago (2015-06-30 16:53:45 UTC) #9
lfg
Instead of adding a UMA metric like that, we should use extensions::bad_message. Those are new ...
5 years, 5 months ago (2015-06-30 16:58:56 UTC) #10
EhsanK
rdevlin.cronin@chromium.org: Please review changes in PTAL.
5 years, 5 months ago (2015-06-30 18:33:26 UTC) #13
EhsanK
On 2015/06/30 16:58:56, lfg wrote: > Instead of adding a UMA metric like that, we ...
5 years, 5 months ago (2015-06-30 18:34:53 UTC) #14
lfg
On 2015/06/30 18:34:53, ehsaaan wrote: > On 2015/06/30 16:58:56, lfg wrote: > > Instead of ...
5 years, 5 months ago (2015-06-30 18:39:56 UTC) #15
Devlin
https://codereview.chromium.org/1181893003/diff/80001/chrome/browser/apps/guest_view/app_view_browsertest.cc File chrome/browser/apps/guest_view/app_view_browsertest.cc (left): https://codereview.chromium.org/1181893003/diff/80001/chrome/browser/apps/guest_view/app_view_browsertest.cc#oldcode4 chrome/browser/apps/guest_view/app_view_browsertest.cc:4: we want this newline. :) https://codereview.chromium.org/1181893003/diff/80001/chrome/browser/apps/guest_view/app_view_browsertest.cc File chrome/browser/apps/guest_view/app_view_browsertest.cc (right): ...
5 years, 5 months ago (2015-06-30 19:54:11 UTC) #16
EhsanK
PTAL. https://codereview.chromium.org/1181893003/diff/80001/chrome/browser/apps/guest_view/app_view_browsertest.cc File chrome/browser/apps/guest_view/app_view_browsertest.cc (left): https://codereview.chromium.org/1181893003/diff/80001/chrome/browser/apps/guest_view/app_view_browsertest.cc#oldcode4 chrome/browser/apps/guest_view/app_view_browsertest.cc:4: On 2015/06/30 19:54:10, Devlin wrote: > we want ...
5 years, 5 months ago (2015-07-02 19:15:14 UTC) #17
lfg
lgtm with nits. https://codereview.chromium.org/1181893003/diff/120001/chrome/browser/apps/guest_view/app_view_browsertest.cc File chrome/browser/apps/guest_view/app_view_browsertest.cc (right): https://codereview.chromium.org/1181893003/diff/120001/chrome/browser/apps/guest_view/app_view_browsertest.cc#newcode10 chrome/browser/apps/guest_view/app_view_browsertest.cc:10: #include "content/public/browser/notification_observer.h" Is this needed? https://codereview.chromium.org/1181893003/diff/120001/extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc ...
5 years, 5 months ago (2015-07-06 18:46:21 UTC) #18
Devlin
lgtm with nits https://codereview.chromium.org/1181893003/diff/120001/chrome/browser/apps/guest_view/app_view_browsertest.cc File chrome/browser/apps/guest_view/app_view_browsertest.cc (right): https://codereview.chromium.org/1181893003/diff/120001/chrome/browser/apps/guest_view/app_view_browsertest.cc#newcode38 chrome/browser/apps/guest_view/app_view_browsertest.cc:38: message_loop_runner_(nullptr) { nit: scoped_refptrs default to ...
5 years, 5 months ago (2015-07-06 20:18:08 UTC) #19
EhsanK
Thanks! PTAL. https://codereview.chromium.org/1181893003/diff/120001/chrome/browser/apps/guest_view/app_view_browsertest.cc File chrome/browser/apps/guest_view/app_view_browsertest.cc (right): https://codereview.chromium.org/1181893003/diff/120001/chrome/browser/apps/guest_view/app_view_browsertest.cc#newcode10 chrome/browser/apps/guest_view/app_view_browsertest.cc:10: #include "content/public/browser/notification_observer.h" On 2015/07/06 18:46:21, lfg wrote: ...
5 years, 5 months ago (2015-07-06 21:09:59 UTC) #20
lfg
Still lgtm.
5 years, 5 months ago (2015-07-06 21:39:31 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181893003/140001
5 years, 5 months ago (2015-07-07 14:42:22 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/76442)
5 years, 5 months ago (2015-07-07 14:50:21 UTC) #26
Fady Samuel
lgtm
5 years, 5 months ago (2015-07-07 15:01:38 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181893003/140001
5 years, 5 months ago (2015-07-07 15:03:07 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/77395) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 5 months ago (2015-07-07 16:28:11 UTC) #32
lfg
On 2015/07/07 16:28:11, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 5 months ago (2015-07-07 19:27:19 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181893003/160001
5 years, 5 months ago (2015-07-07 19:39:51 UTC) #36
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 5 months ago (2015-07-07 22:15:07 UTC) #37
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 22:16:02 UTC) #38
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/725a6cae963a44de80afec2e3cd9d597fecf7b7d
Cr-Commit-Position: refs/heads/master@{#337692}

Powered by Google App Engine
This is Rietveld 408576698