Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: extensions/browser/guest_view/app_view/app_view_guest.h

Issue 1181893003: Kill bad apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed Check for Termination Status (Windows Problems) Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/bad_message.h ('k') | extensions/browser/guest_view/app_view/app_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/app_view/app_view_guest.h
diff --git a/extensions/browser/guest_view/app_view/app_view_guest.h b/extensions/browser/guest_view/app_view/app_view_guest.h
index 81cf44de0d745606a717b4e6b02be583bc753e99..d9f09013dd22015a8db250dfa357afc183dae763 100644
--- a/extensions/browser/guest_view/app_view/app_view_guest.h
+++ b/extensions/browser/guest_view/app_view/app_view_guest.h
@@ -22,15 +22,25 @@ class AppViewGuest : public guest_view::GuestView<AppViewGuest> {
static const char Type[];
// Completes the creation of a WebContents associated with the provided
- // |guest_extensions_id|.
+ // |guest_extension_id| and |guest_instance_id| for the given
+ // |browser_context|.
+ // |guest_render_process_host| is the RenderProcessHost and |url| is the
+ // resource GURL of the extension instance making this request. If there is
+ // any mismatch between the expected |guest_instance_id| and
+ // |guest_extension_id| provided and the recorded copies from when the the
+ // <appview> was created, the RenderProcessHost of the extension instance
+ // behind this request will be killed.
static bool CompletePendingRequest(
content::BrowserContext* browser_context,
const GURL& url,
int guest_instance_id,
- const std::string& guest_extension_id);
+ const std::string& guest_extension_id,
+ content::RenderProcessHost* guest_render_process_host);
static GuestViewBase* Create(content::WebContents* owner_web_contents);
+ static std::vector<int> GetAllRegisteredInstanceIdsForTesting();
+
// content::WebContentsDelegate implementation.
bool HandleContextMenu(const content::ContextMenuParams& params) override;
void RequestMediaAccessPermission(
« no previous file with comments | « extensions/browser/bad_message.h ('k') | extensions/browser/guest_view/app_view/app_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698