Don't allow inline block comments to eat pending newlines.

Don't allow inline block comments to eat pending newlines.

Fix #178.

R=pquitslund@google.com

Committed: 6ed55b93f5b08f53046e8856ad0e7cee12fdca34

[Bob Nystrom, 2015-06-10 16:39:31]

rnystrom@google.com changed reviewers:
+ kevmoo@google.com, pquitslund@google.com

[pquitslund, 2015-06-10 17:01:50]

lgtm

https://chromiumcodereview.appspot.com/1180443003/diff/1/test/regression/178....
File test/regression/178.unit (right):

https://chromiumcodereview.appspot.com/1180443003/diff/1/test/regression/178....
test/regression/178.unit:9: /* soup */
Out of curiosity, how does this format?

import 'dart:async'; /* soup */
import 'dart:io';

I would *hope* it leaves the comment well enough alone (and not shove it to a
newline)?

[Bob Nystrom, 2015-06-10 17:14:45]

Committed patchset #2 (id:20001) manually as
6ed55b93f5b08f53046e8856ad0e7cee12fdca34 (presubmit successful).

[Bob Nystrom, 2015-06-10 17:15:16]

https://chromiumcodereview.appspot.com/1180443003/diff/1/test/regression/178....
File test/regression/178.unit (right):

https://chromiumcodereview.appspot.com/1180443003/diff/1/test/regression/178....
test/regression/178.unit:9: /* soup */
On 2015/06/10 17:01:50, pquitslund wrote:
> Out of curiosity, how does this format?
> 
> import 'dart:async'; /* soup */
> import 'dart:io';
> 
> I would *hope* it leaves the comment well enough alone (and not shove it to a
> newline)?

Yeah, it leaves that alone. The check for this corner case in chunk_builder.dart
is quite precise. There have to be no newlines anywhere between the previous
token and the token after the comment(s).

Added a test.