test/regression/178.unit - Issue 1180443003: Don't allow inline block comments to eat pending newlines.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/regression/178.unit

Issue 1180443003: Don't allow inline block comments to eat pending newlines. (Closed) Base URL: https://github.com/dart-lang/dart_style.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 >>>

	2 import 'dart:async'; /* soup */ import 'dart:io';

	3

	4 void main() {

	5 print('hi');

	6 }

	7 <<<

	8 import 'dart:async';

	9 /* soup */
	pquitslund 2015/06/10 17:01:50 Out of curiosity, how does this format? import 'd Out of curiosity, how does this format? import 'dart:async'; /* soup / import 'dart:io'; I would hope* it leaves the comment well enough alone (and not shove it to a newline)? Bob Nystrom 2015/06/10 17:15:15 Yeah, it leaves that alone. The check for this cor Show quoted text On 2015/06/10 17:01:50, pquitslund wrote: > Out of curiosity, how does this format? > > import 'dart:async'; /* soup / > import 'dart:io'; > > I would hope* it leaves the comment well enough alone (and not shove it to a > newline)? Yeah, it leaves that alone. The check for this corner case in chunk_builder.dart is quite precise. There have to be no newlines anywhere between the previous token and the token after the comment(s). Added a test.
	10 import 'dart:io';

	11

	12 void main() {

	13 print('hi');

	14 }

OLD	NEW

« no previous file with comments | « test/comments/top_level.unit ('k') | no next file » | no next file with comments »