Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(39)

Issue 1179713004: Material and RaisedButton. (Closed)

Created:
3 years, 10 months ago by Hixie
Modified:
3 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Material and RaisedButton. Make Material actually create material, with opinions about what that means. Make FloatingActionButton use this. Make Scrollable use this. Make BoxDecoration support drawing a circle instead of a rectangle, so that floating action button doesn't need a custom painter. Implement RaisedButton (and remove button.dart, since there's no "button" in Material Design). Make InkWell have a "child" argument instead of "children", and not have it introduce a Flex into the hierarchy. Update container.dart example. Clean up some imports. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f505c9c0f781a59a73d9c54ccb0014c2f6472e71

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 8

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -175 lines) Patch
M sky/examples/stocks2/lib/stock_app.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/examples/stocks2/lib/stock_row.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/examples/widgets/container.dart View 1 2 3 4 1 chunk +19 lines, -24 lines 0 comments Download
M sky/examples/widgets/spinning_mixed.dart View 1 2 3 4 2 chunks +7 lines, -3 lines 0 comments Download
M sky/sdk/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/editing2/input.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/painting/box_painter.dart View 5 chunks +28 lines, -9 lines 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 1 2 3 4 6 chunks +108 lines, -13 lines 0 comments Download
M sky/sdk/lib/framework/theme2/colors.dart View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A sky/sdk/lib/framework/theme2/edges.dart View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/theme2/shadows.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D sky/sdk/lib/framework/widgets/button.dart View 1 chunk +0 lines, -33 lines 0 comments Download
M sky/sdk/lib/framework/widgets/drawer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/fixed_height_scrollable.dart View 1 chunk +3 lines, -8 lines 0 comments Download
M sky/sdk/lib/framework/widgets/floating_action_button.dart View 1 2 3 4 2 chunks +15 lines, -31 lines 0 comments Download
M sky/sdk/lib/framework/widgets/ink_well.dart View 2 chunks +2 lines, -19 lines 0 comments Download
M sky/sdk/lib/framework/widgets/material.dart View 1 2 3 4 1 chunk +25 lines, -14 lines 0 comments Download
M sky/sdk/lib/framework/widgets/menu_item.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/widgets/popup_menu.dart View 2 chunks +1 line, -2 lines 0 comments Download
M sky/sdk/lib/framework/widgets/popup_menu_item.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A sky/sdk/lib/framework/widgets/raised_button.dart View 1 2 3 4 1 chunk +55 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/widgets/scrollable.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/widgets/tool_bar.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/ui_node.dart View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/wrappers.dart View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Hixie
One thing that's broken with this is that the + on the fab is the ...
3 years, 10 months ago (2015-06-12 00:37:46 UTC) #1
Hixie
I may also have broken the drawer. Will check on that tomorrow.
3 years, 10 months ago (2015-06-12 00:38:43 UTC) #2
abarth-chromium
LGTM Very nice. You forgot to git add edge.dart https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/widgets/raised_button.dart File sky/sdk/lib/framework/widgets/raised_button.dart (right): https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/widgets/raised_button.dart#newcode43 sky/sdk/lib/framework/widgets/raised_button.dart:43: ...
3 years, 10 months ago (2015-06-12 03:08:05 UTC) #4
Hixie
https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/widgets/raised_button.dart File sky/sdk/lib/framework/widgets/raised_button.dart (right): https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/widgets/raised_button.dart#newcode43 sky/sdk/lib/framework/widgets/raised_button.dart:43: ) On 2015/06/12 at 03:08:04, abarth wrote: > We ...
3 years, 10 months ago (2015-06-12 17:36:38 UTC) #5
abarth-chromium
lgtm
3 years, 10 months ago (2015-06-12 18:45:56 UTC) #6
Hixie
3 years, 10 months ago (2015-06-12 18:46:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
f505c9c0f781a59a73d9c54ccb0014c2f6472e71 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698