Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 11788019: Create favicon tab helpers for blocked popups. (Closed)

Created:
7 years, 11 months ago by Avi (use Gerrit)
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Create favicon tab helpers for blocked popups. BUG=167457 TEST=no more crashes in the crash server Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/blocked_content/blocked_content_container.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
7 years, 11 months ago (2013-01-07 21:56:04 UTC) #1
sky
LGTM
7 years, 11 months ago (2013-01-07 22:00:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11788019/1
7 years, 11 months ago (2013-01-07 22:03:18 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 01:08:18 UTC) #4
Message was sent while issue was closed.
Change committed as 175438

Powered by Google App Engine
This is Rietveld 408576698