Create favicon tab helpers for blocked popups.

chrome/browser/ui/blocked_content/blocked_content_container.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/blocked_content/blocked_content_container.h"
 
 #include "base/logging.h"
+#include "chrome/browser/favicon/favicon_tab_helper.h"
 #include "chrome/browser/ui/blocked_content/blocked_content_tab_helper.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/gfx/rect.h"
 
 using content::OpenURLParams;
 using content::WebContents;
 
 // static
 const size_t BlockedContentContainer::kImpossibleNumberOfPopups = 30;
 
@@ skipping 31 matching lines @@
     VLOG(1) << "Warning: Renderer is sending more popups to us than should be "
                "possible. Renderer compromised?";
     return;
   }
 
   blocked_contents_.push_back(
       BlockedContent(web_contents, disposition, bounds, user_gesture));
   web_contents->SetDelegate(this);
 
   BlockedContentTabHelper::CreateForWebContents(web_contents);
+  // Various UI parts assume the ability to retrieve favicons from blocked
+  // content.
+  FaviconTabHelper::CreateForWebContents(web_contents);
   BlockedContentTabHelper::FromWebContents(web_contents)->set_delegate(this);
 
   // Since the new web_contents will not be shown, call WasHidden to change
   // its status on both RenderViewHost and RenderView.
   web_contents->WasHidden();
 }
 
 void BlockedContentContainer::LaunchForContents(
     content::WebContents* web_contents) {
   // Open the popup.
@@ skipping 104 matching lines @@
 bool BlockedContentContainer::ShouldSuppressDialogs() {
   // Suppress JavaScript dialogs when inside a constrained popup window (because
   // that activates them and breaks them out of the constrained window jail).
   return true;
 }
 
 content::WebContents* BlockedContentContainer::GetConstrainingWebContents(
     content::WebContents* source) {
   return owner_;
 }