Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3588)

Unified Diff: chrome/browser/ui/blocked_content/blocked_content_container.cc

Issue 11788019: Create favicon tab helpers for blocked popups. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/blocked_content/blocked_content_container.cc
diff --git a/chrome/browser/ui/blocked_content/blocked_content_container.cc b/chrome/browser/ui/blocked_content/blocked_content_container.cc
index f6999c73e7a2662637c7591ec8bc4aed3540bd7b..e659baeac46ad4d9432ae3ef9ccd05fa8a13cc4c 100644
--- a/chrome/browser/ui/blocked_content/blocked_content_container.cc
+++ b/chrome/browser/ui/blocked_content/blocked_content_container.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/blocked_content/blocked_content_container.h"
#include "base/logging.h"
+#include "chrome/browser/favicon/favicon_tab_helper.h"
#include "chrome/browser/ui/blocked_content/blocked_content_tab_helper.h"
#include "content/public/browser/web_contents.h"
#include "ui/gfx/rect.h"
@@ -56,6 +57,9 @@ void BlockedContentContainer::AddWebContents(content::WebContents* web_contents,
web_contents->SetDelegate(this);
BlockedContentTabHelper::CreateForWebContents(web_contents);
+ // Various UI parts assume the ability to retrieve favicons from blocked
+ // content.
+ FaviconTabHelper::CreateForWebContents(web_contents);
BlockedContentTabHelper::FromWebContents(web_contents)->set_delegate(this);
// Since the new web_contents will not be shown, call WasHidden to change
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698