Issue 11783018: Fix crash and failures in ash_unittests with the new focus controller by disabling launcher activat…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11783018: Fix crash and failures in ash_unittests with the new focus controller by disabling launcher activat… (Closed)

Created:
7 years, 11 months ago by Ben Goodger (Google)

Modified:
7 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, mtomasz

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix crash and failures in ash_unittests with the new focus controller by disabling launcher activation fallback tests. mtomasz, your fallback code will probably stop working once the FocusController is turned on. You should be running with --use-focus-controller when making changes like this, and making sure your change works in this state. BUG=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176148

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	ash/launcher/launcher_unittest.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	ash/wm/ash_activation_controller_unittest.cc	View		3 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/11783018/1

7 years, 11 months ago (2013-01-07 22:43:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/11783018/1

7 years, 11 months ago (2013-01-10 19:26:18 UTC) #4

Message was sent while issue was closed.

Change committed as 176148

Expand Messages | Collapse Messages