Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: ash/launcher/launcher_unittest.cc

Issue 11783018: Fix crash and failures in ash_unittests with the new focus controller by disabling launcher activat… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ash/wm/ash_activation_controller_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/launcher/launcher.h" 5 #include "ash/launcher/launcher.h"
6 #include "ash/launcher/launcher_button.h" 6 #include "ash/launcher/launcher_button.h"
7 #include "ash/launcher/launcher_model.h" 7 #include "ash/launcher/launcher_model.h"
8 #include "ash/launcher/launcher_view.h" 8 #include "ash/launcher/launcher_view.h"
9 9
10 #include "ash/shell.h" 10 #include "ash/shell.h"
11 #include "ash/test/ash_test_base.h" 11 #include "ash/test/ash_test_base.h"
12 #include "ash/test/launcher_view_test_api.h" 12 #include "ash/test/launcher_view_test_api.h"
13 #include "ash/wm/window_util.h" 13 #include "ash/wm/window_util.h"
14 #include "ui/views/corewm/corewm_switches.h"
14 #include "ui/views/view.h" 15 #include "ui/views/view.h"
15 #include "ui/views/widget/widget.h" 16 #include "ui/views/widget/widget.h"
16 17
17 typedef ash::test::AshTestBase LauncherTest; 18 typedef ash::test::AshTestBase LauncherTest;
18 using ash::internal::LauncherView; 19 using ash::internal::LauncherView;
19 using ash::internal::LauncherButton; 20 using ash::internal::LauncherButton;
20 21
21 namespace ash { 22 namespace ash {
22 23
23 // Makes sure invoking SetStatusSize on the launcher changes the size of the 24 // Makes sure invoking SetStatusSize on the launcher changes the size of the
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 } 102 }
102 103
103 // Shows overflow bubble. 104 // Shows overflow bubble.
104 test.ShowOverflowBubble(); 105 test.ShowOverflowBubble();
105 EXPECT_TRUE(launcher->IsShowingOverflowBubble()); 106 EXPECT_TRUE(launcher->IsShowingOverflowBubble());
106 } 107 }
107 108
108 // Launcher can't be activated on mouse click, but it is activable from 109 // Launcher can't be activated on mouse click, but it is activable from
109 // the focus cycler or as fallback. 110 // the focus cycler or as fallback.
110 TEST_F(LauncherTest, ActivateAsFallback) { 111 TEST_F(LauncherTest, ActivateAsFallback) {
112 // TODO(mtomasz): make this test work with the FocusController.
113 if (views::corewm::UseFocusController())
114 return;
115
111 Launcher* launcher = Launcher::ForPrimaryDisplay(); 116 Launcher* launcher = Launcher::ForPrimaryDisplay();
112 views::Widget* launcher_widget = launcher->widget(); 117 views::Widget* launcher_widget = launcher->widget();
113 EXPECT_FALSE(launcher_widget->CanActivate()); 118 EXPECT_FALSE(launcher_widget->CanActivate());
114 119
115 launcher->WillActivateAsFallback(); 120 launcher->WillActivateAsFallback();
116 EXPECT_TRUE(launcher_widget->CanActivate()); 121 EXPECT_TRUE(launcher_widget->CanActivate());
117 122
118 wm::ActivateWindow(launcher_widget->GetNativeWindow()); 123 wm::ActivateWindow(launcher_widget->GetNativeWindow());
119 EXPECT_FALSE(launcher_widget->CanActivate()); 124 EXPECT_FALSE(launcher_widget->CanActivate());
120 } 125 }
121 126
122 } // namespace ash 127 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | ash/wm/ash_activation_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698