Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: ash/wm/ash_activation_controller_unittest.cc

Issue 11783018: Fix crash and failures in ash_unittests with the new focus controller by disabling launcher activat… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ash/launcher/launcher_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/wm/ash_activation_controller.h" 5 #include "ash/wm/ash_activation_controller.h"
6 6
7 #include "ash/launcher/launcher.h" 7 #include "ash/launcher/launcher.h"
8 #include "ash/root_window_controller.h" 8 #include "ash/root_window_controller.h"
9 #include "ash/shell_delegate.h" 9 #include "ash/shell_delegate.h"
10 #include "ash/test/ash_test_base.h" 10 #include "ash/test/ash_test_base.h"
11 #include "ash/wm/property_util.h" 11 #include "ash/wm/property_util.h"
12 #include "ash/wm/window_util.h" 12 #include "ash/wm/window_util.h"
13 #include "ui/aura/window.h" 13 #include "ui/aura/window.h"
14 #include "ui/views/corewm/corewm_switches.h"
14 15
15 namespace ash { 16 namespace ash {
16 17
17 namespace wm { 18 namespace wm {
18 19
19 namespace { 20 namespace {
20 21
21 class AshActivationControllerTest : public test::AshTestBase { 22 class AshActivationControllerTest : public test::AshTestBase {
22 public: 23 public:
23 AshActivationControllerTest() 24 AshActivationControllerTest()
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 // a launcher as fallback, which would result in segmentation faults since 84 // a launcher as fallback, which would result in segmentation faults since
84 // the launcher's window or the workspace's controller may be already 85 // the launcher's window or the workspace's controller may be already
85 // destroyed. 86 // destroyed.
86 GetRootWindowController(Shell::GetActiveRootWindow())->CloseChildWindows(); 87 GetRootWindowController(Shell::GetActiveRootWindow())->CloseChildWindows();
87 88
88 aura::Window* result = ash_activation_controller_->WillActivateWindow(NULL); 89 aura::Window* result = ash_activation_controller_->WillActivateWindow(NULL);
89 EXPECT_EQ(NULL, result); 90 EXPECT_EQ(NULL, result);
90 } 91 }
91 92
92 TEST_F(AshActivationControllerTest, LauncherEndToEndFallbackOnDestroyTest) { 93 TEST_F(AshActivationControllerTest, LauncherEndToEndFallbackOnDestroyTest) {
94 // TODO(mtomasz): make this test work with the FocusController.
95 if (views::corewm::UseFocusController())
96 return;
97
93 // This test checks the whole fallback activation flow. 98 // This test checks the whole fallback activation flow.
94 SetSpokenFeedbackState(true); 99 SetSpokenFeedbackState(true);
95 100
96 scoped_ptr<aura::Window> test_window(CreateTestWindowInShellWithId(0)); 101 scoped_ptr<aura::Window> test_window(CreateTestWindowInShellWithId(0));
97 ActivateWindow(test_window.get()); 102 ActivateWindow(test_window.get());
98 ASSERT_EQ(test_window.get(), GetActiveWindow()); 103 ASSERT_EQ(test_window.get(), GetActiveWindow());
99 104
100 // Close the window. 105 // Close the window.
101 test_window.reset(); 106 test_window.reset();
102 107
103 // Verify if the launcher got activated as fallback. 108 // Verify if the launcher got activated as fallback.
104 ASSERT_EQ(launcher_window_, GetActiveWindow()); 109 ASSERT_EQ(launcher_window_, GetActiveWindow());
105 } 110 }
106 111
107 TEST_F(AshActivationControllerTest, LauncherEndToEndFallbackOnMinimizeTest) { 112 TEST_F(AshActivationControllerTest, LauncherEndToEndFallbackOnMinimizeTest) {
113 // TODO(mtomasz): make this test work with the FocusController.
114 if (views::corewm::UseFocusController())
115 return;
116
108 // This test checks the whole fallback activation flow. 117 // This test checks the whole fallback activation flow.
109 SetSpokenFeedbackState(true); 118 SetSpokenFeedbackState(true);
110 119
111 scoped_ptr<aura::Window> test_window(CreateTestWindowInShellWithId(0)); 120 scoped_ptr<aura::Window> test_window(CreateTestWindowInShellWithId(0));
112 ActivateWindow(test_window.get()); 121 ActivateWindow(test_window.get());
113 ASSERT_EQ(test_window.get(), GetActiveWindow()); 122 ASSERT_EQ(test_window.get(), GetActiveWindow());
114 123
115 // Minimize the window. 124 // Minimize the window.
116 MinimizeWindow(test_window.get()); 125 MinimizeWindow(test_window.get());
117 126
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 158
150 // Verify if the launcher didn't get activated as fallback. 159 // Verify if the launcher didn't get activated as fallback.
151 ASSERT_NE(launcher_window_, GetActiveWindow()); 160 ASSERT_NE(launcher_window_, GetActiveWindow());
152 } 161 }
153 162
154 } // namespace 163 } // namespace
155 164
156 } // namespace wm 165 } // namespace wm
157 166
158 } // namespace ash 167 } // namespace ash
OLDNEW
« no previous file with comments | « ash/launcher/launcher_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698