Start unifying document-mode and tabbed-mode tab creation

Start unifying document-mode and tabbed-mode tab creation

* TabDelegate, which is used to create tabs in document-mode
  now subclasses the TabCreator class that tabbed-mode uses.

* Being consolidating methods for creating tabs in the TabDelegate
  class.

  - Various methods for opening new Tabs under specific conditions
    (e.g. for devtools, or for opening an NTP) in document mode are
    cleaned up.

  - DocumentActivity's SingleTabModelSelector now defers to the
    DocumentTabModelSelector when opening new Tabs.

  - DocumentTabModelImpl uses generic methods in TabDelegate to
    create Tabs as similarly as possible to the TabModelImpl.
    In contrast to how TabModelImpl works with
    ChromeTabbedActivity, the DocumentTabModel has no specific
    Activity to grab TabCreators from.  Instead, the
    DocumentTabModelSelector becomes a TabCreatorManager and
    passes out its TabCreators when necessary.

* TabCreator.createFrozenTab now returns a Tab to line up with how
  document mode creates frozen tabs.

* DocumentTabChromeWebContentsDelegateAndroidImpl no longer stores
  a mapping between the WebContents' URL and its native pointer.
  Instead, the URL is grabbed via JNI before the new Activity is
  launched.

BUG=451453
Committed: https://crrev.com/05c376f220bbffbc20ba6f5d8f1b42091467f12a
Cr-Commit-Position: refs/heads/master@{#334098}

[gone, 2015-06-10 18:17:15]

dfalcantara@chromium.org changed reviewers:
+ dtrainor@chromium.org, mariakhomenko@chromium.org, tedchoc@chromium.org

[gone, 2015-06-10 18:17:15]

This change is coming down the pipe, FYI.  I'm trying to figure out how to test
the rather ridiculous number of ways that we can trigger a Tab to be created,
but this CL seems to handle the current use cases correctly via manual testing. 
It'd be great if you could all take a cursory look at what I'm doing and tell me
if I'm doing something egregiously bad.

Thanks!

[Ted C, 2015-06-11 19:25:58]

lgtm

https://chromiumcodereview.appspot.com/1176943002/diff/20001/chrome/android/j...
File
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java
(right):

https://chromiumcodereview.appspot.com/1176943002/diff/20001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java:882:
} catch (Exception e) {
findbugs will probably complain about this being empty

[gone, 2015-06-11 20:26:54]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-11 20:27:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176943002/20001

[gone, 2015-06-11 20:27:41]

Going to add follow up unit tests once this and
https://chromiumcodereview.appspot.com/1178223003/ both land.

https://chromiumcodereview.appspot.com/1176943002/diff/20001/chrome/android/j...
File
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java
(right):

https://chromiumcodereview.appspot.com/1176943002/diff/20001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java:882:
} catch (Exception e) {
On 2015/06/11 19:25:58, Ted C wrote:
> findbugs will probably complain about this being empty

Seems fine when I compile it locally.  Running it through the bots.

[commit-bot: I haz the power, 2015-06-11 21:44:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 21:44:48]

Dry run: This issue passed the CQ dry run.

[Maria, 2015-06-11 23:08:50]

lgtm

https://chromiumcodereview.appspot.com/1176943002/diff/20001/chrome/android/j...
File
chrome/android/java_staging/src/org/chromium/chrome/browser/document/TabDelegateImpl.java
(right):

https://chromiumcodereview.appspot.com/1176943002/diff/20001/chrome/android/j...
chrome/android/java_staging/src/org/chromium/chrome/browser/document/TabDelegateImpl.java:71:
data.webContentsPaused = startedBy !=
DocumentMetricIds.STARTED_BY_CHROME_HOME_RECENT_TABS;
this is a little scary. How about a TODO to get this information from native? I
think we could pipe this bit.

Also what about web workers? They don't pause contents, but I thought they go
through this path?

[gone, 2015-06-12 00:12:19]

https://chromiumcodereview.appspot.com/1176943002/diff/20001/chrome/android/j...
File
chrome/android/java_staging/src/org/chromium/chrome/browser/document/TabDelegateImpl.java
(right):

https://chromiumcodereview.appspot.com/1176943002/diff/20001/chrome/android/j...
chrome/android/java_staging/src/org/chromium/chrome/browser/document/TabDelegateImpl.java:71:
data.webContentsPaused = startedBy !=
DocumentMetricIds.STARTED_BY_CHROME_HOME_RECENT_TABS;
On 2015/06/11 23:08:49, Maria wrote:
> this is a little scary. How about a TODO to get this information from native?
I
> think we could pipe this bit.
> 
> Also what about web workers? They don't pause contents, but I thought they go
> through this path?

Added a TODO.  I couldn't get web workers to go through this path.  Not sure how
they create Tabs but it doesn't seem to be through here (at least in Document
mode).

[gone, 2015-06-12 00:12:31]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2015-06-12 00:12:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, mariakhomenko@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1176943002/#ps40001
(title: "Comment")

[commit-bot: I haz the power, 2015-06-12 00:13:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1176943002/40001

[commit-bot: I haz the power, 2015-06-12 01:05:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-12 01:06:15]

Patchset 3 (id:??) landed as
https://crrev.com/05c376f220bbffbc20ba6f5d8f1b42091467f12a
Cr-Commit-Position: refs/heads/master@{#334098}