chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java - Issue 1176943002: Start unifying document-mode and tabbed-mode tab creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java

Issue 1176943002: Start unifying document-mode and tabbed-mode tab creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java

index c06de536b663a10319f2044f9aefb1f5156c8bf9..c0a544955af25811904f382ccaed128f1da5c8f4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java

@@ -34,7 +34,7 @@ public interface TabCreatorManager {

* @param id The id to give the new tab.

* @param index The index for where to place the tab.

- void createFrozenTab(TabState state, int id, int index);

+ Tab createFrozenTab(TabState state, int id, int index);

/**

* Creates a tab around the native web contents pointer.

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java » ('j') | no next file with comments »