chrome/android/java_staging/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java - Issue 1176943002: Start unifying document-mode and tabbed-mode tab creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

Issue 1176943002: Start unifying document-mode and tabbed-mode tab creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_staging/src/org/chromium/chrome/browser/document/TabDelegateImpl.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

index 80ca244d3600c9e71374498cc473a56ddf3a426b..b45a45a7b8a873609a5b06f58409b9fefdbd86d6 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

@@ -261,7 +261,7 @@ public class ChromeTabCreator implements TabCreatorManager.TabCreator {

}

@Override

- public void createFrozenTab(TabState state, int id, int index) {

+ public Tab createFrozenTab(TabState state, int id, int index) {

ChromeTab tab = ChromeTab.createFrozenTabFromState(

id, mActivity, state.isIncognito(), mNativeWindow, state.parentId, state);

boolean selectTab = mOrderController.willOpenInForeground(TabLaunchType.FROM_RESTORE,

@@ -269,6 +269,7 @@ public class ChromeTabCreator implements TabCreatorManager.TabCreator {

tab.initialize(null, mTabContentManager, !selectTab);

assert state.isIncognito() == mIncognito;

mTabModel.addTab(tab, index, TabLaunchType.FROM_RESTORE);

+ return tab;

}

/**