Source/core/layout/LayoutFieldset.h - Issue 1173853005: LayoutFieldSet::computePreferredLogicalWidths uses marginLeft for marginRight by mistake

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutFieldset.h

Issue 1173853005: LayoutFieldSet::computePreferredLogicalWidths uses marginLeft for marginRight by mistake Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding Layout Tests after removing the functions Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutFieldset.h

diff --git a/Source/core/layout/LayoutFieldset.h b/Source/core/layout/LayoutFieldset.h

index d1de67cdc9c9017c7eb8ce7b3fed5f9d20a610a7..26356afc166e123a2ead8ea07a55d90bcd29ec96 100644

--- a/Source/core/layout/LayoutFieldset.h

+++ b/Source/core/layout/LayoutFieldset.h

@@ -42,7 +42,6 @@ private:

virtual LayoutObject* layoutSpecialExcludedChild(bool relayoutChildren, SubtreeLayoutScope&) override;

- virtual void computePreferredLogicalWidths() override;

a.suchit2 2015/07/09 10:09:54 Do not remove this function. Earlier changes are

virtual bool avoidsFloats() const override { return true; }

virtual void paintBoxDecorationBackground(const PaintInfo&, const LayoutPoint&) override;

« no previous file with comments | « LayoutTests/fast/block/basic/fieldset-with-legend-expected.txt ('k') | Source/core/layout/LayoutFieldset.cpp » ('j') | no next file with comments »