Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: Source/core/layout/LayoutFieldset.h

Issue 1173853005: LayoutFieldSet::computePreferredLogicalWidths uses marginLeft for marginRight by mistake Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding Layout Tests after removing the functions Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2006, 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2006, 2009 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 24 matching lines...) Expand all
35 enum FindLegendOption { IgnoreFloatingOrOutOfFlow, IncludeFloatingOrOutOfFlo w }; 35 enum FindLegendOption { IgnoreFloatingOrOutOfFlow, IncludeFloatingOrOutOfFlo w };
36 LayoutBox* findLegend(FindLegendOption = IgnoreFloatingOrOutOfFlow) const; 36 LayoutBox* findLegend(FindLegendOption = IgnoreFloatingOrOutOfFlow) const;
37 37
38 virtual const char* name() const override { return "LayoutFieldset"; } 38 virtual const char* name() const override { return "LayoutFieldset"; }
39 39
40 private: 40 private:
41 virtual bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectFieldset || LayoutBlockFlow::isOfType(type); } 41 virtual bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectFieldset || LayoutBlockFlow::isOfType(type); }
42 42
43 virtual LayoutObject* layoutSpecialExcludedChild(bool relayoutChildren, Subt reeLayoutScope&) override; 43 virtual LayoutObject* layoutSpecialExcludedChild(bool relayoutChildren, Subt reeLayoutScope&) override;
44 44
45 virtual void computePreferredLogicalWidths() override;
a.suchit2 2015/07/09 10:09:54 Do not remove this function. Earlier changes are
46 virtual bool avoidsFloats() const override { return true; } 45 virtual bool avoidsFloats() const override { return true; }
47 46
48 virtual void paintBoxDecorationBackground(const PaintInfo&, const LayoutPoin t&) override; 47 virtual void paintBoxDecorationBackground(const PaintInfo&, const LayoutPoin t&) override;
49 virtual void paintMask(const PaintInfo&, const LayoutPoint&) override; 48 virtual void paintMask(const PaintInfo&, const LayoutPoint&) override;
50 }; 49 };
51 50
52 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutFieldset, isFieldset()); 51 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutFieldset, isFieldset());
53 52
54 } // namespace blink 53 } // namespace blink
55 54
56 #endif // LayoutFieldset_h 55 #endif // LayoutFieldset_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/block/basic/fieldset-with-legend-expected.txt ('k') | Source/core/layout/LayoutFieldset.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698