Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: Source/core/layout/LayoutFieldset.cpp

Issue 1173853005: LayoutFieldSet::computePreferredLogicalWidths uses marginLeft for marginRight by mistake Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding Layout Tests after removing the functions Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/layout/LayoutFieldset.h ('K') | « Source/core/layout/LayoutFieldset.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutFieldset.cpp
diff --git a/Source/core/layout/LayoutFieldset.cpp b/Source/core/layout/LayoutFieldset.cpp
index a08e0042a20f7d8665bfd883a20687113cd23c26..1cdd5b12477f27b0e240e80d5670800a07009e26 100644
--- a/Source/core/layout/LayoutFieldset.cpp
+++ b/Source/core/layout/LayoutFieldset.cpp
@@ -42,25 +42,6 @@ LayoutFieldset::LayoutFieldset(Element* element)
{
}
-void LayoutFieldset::computePreferredLogicalWidths()
-{
- LayoutBlockFlow::computePreferredLogicalWidths();
- if (LayoutBox* legend = findLegend()) {
- int legendMinWidth = legend->minPreferredLogicalWidth();
-
- Length legendMarginLeft = legend->style()->marginLeft();
- Length legendMarginRight = legend->style()->marginLeft();
-
- if (legendMarginLeft.isFixed())
- legendMinWidth += legendMarginLeft.value();
-
- if (legendMarginRight.isFixed())
- legendMinWidth += legendMarginRight.value();
-
- m_minPreferredLogicalWidth = max(m_minPreferredLogicalWidth, legendMinWidth + borderAndPaddingWidth());
- }
-}
-
LayoutObject* LayoutFieldset::layoutSpecialExcludedChild(bool relayoutChildren, SubtreeLayoutScope&)
{
LayoutBox* legend = findLegend();
« Source/core/layout/LayoutFieldset.h ('K') | « Source/core/layout/LayoutFieldset.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698