Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 11678006: Revert r13188, r13194, r13256 (Deferred formatting of error stack trace during GC). (Closed)

Created:
7 years, 12 months ago by Yang
Modified:
7 years, 12 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Revert r13188, r13194, r13256 (Deferred formatting of error stack trace during GC). R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13279

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -487 lines) Patch
M src/api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/handles.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/heap.h View 4 chunks +0 lines, -42 lines 0 comments Download
M src/heap.cc View 7 chunks +0 lines, -118 lines 0 comments Download
M src/heap-inl.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/list.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/list-inl.h View 2 chunks +1 line, -10 lines 0 comments Download
M src/mark-compact.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M src/messages.js View 7 chunks +39 lines, -81 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/runtime.cc View 1 chunk +5 lines, -35 lines 0 comments Download
M test/cctest/test-decls.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/message/overwritten-builtins.out View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/eval-stack-trace.js View 1 chunk +4 lines, -5 lines 0 comments Download
M test/mjsunit/stack-traces.js View 1 chunk +1 line, -39 lines 0 comments Download
D test/mjsunit/stack-traces-gc.js View 1 chunk +0 lines, -119 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
7 years, 12 months ago (2012-12-27 13:10:31 UTC) #1
ulan
7 years, 12 months ago (2012-12-27 13:12:08 UTC) #2
LGTM (rubber-stamp)

Powered by Google App Engine
This is Rietveld 408576698