Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: test/mjsunit/stack-traces.js

Issue 11678006: Revert r13188, r13194, r13256 (Deferred formatting of error stack trace during GC). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/eval-stack-trace.js ('k') | test/mjsunit/stack-traces-gc.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/stack-traces.js
diff --git a/test/mjsunit/stack-traces.js b/test/mjsunit/stack-traces.js
index b5d58fa0759f3086bce84d139824114d0b80d505..438eec979d1766ed831a45c594bc29b8e9beab7a 100644
--- a/test/mjsunit/stack-traces.js
+++ b/test/mjsunit/stack-traces.js
@@ -288,42 +288,4 @@ testOmittedBuiltin(function(){ [thrower, 2].sort(function (a,b) {
}, "QuickSort");
// Omitted because ADD from runtime.js is non-native builtin.
-testOmittedBuiltin(function(){ thrower + 2; }, "ADD");
-
-var error = new Error();
-error.toString = function() { assertUnreachable(); };
-error.stack;
-
-error = new Error();
-error.name = { toString: function() { assertUnreachable(); }};
-error.message = { toString: function() { assertUnreachable(); }};
-error.stack;
-
-error = new Error();
-Array.prototype.push = function(x) { assertUnreachable(); };
-Array.prototype.join = function(x) { assertUnreachable(); };
-error.stack;
-
-var fired = false;
-error = new Error({ toString: function() { fired = true; } });
-assertTrue(fired);
-error.stack;
-assertTrue(fired);
-
-// Check that throwing exception in a custom stack trace formatting function
-// does not lead to recursion.
-Error.prepareStackTrace = function() { throw new Error("abc"); };
-var message;
-try {
- throw new Error();
-} catch (e) {
- message = e.message;
-}
-
-assertEquals("abc", message);
-
-// Test that modifying Error.prepareStackTrace by itself works.
-Error.prepareStackTrace = function() { Error.prepareStackTrace = "custom"; };
-new Error();
-
-assertEquals("custom", Error.prepareStackTrace);
+testOmittedBuiltin(function(){ thrower + 2; }, "ADD");
« no previous file with comments | « test/mjsunit/eval-stack-trace.js ('k') | test/mjsunit/stack-traces-gc.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698