test/cctest/test-heap.cc - Issue 11678006: Revert r13188, r13194, r13256 (Deferred formatting of error stack trace during GC).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap.cc

Issue 11678006: Revert r13188, r13194, r13256 (Deferred formatting of error stack trace during GC). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-heap.cc

diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc

index 1e43d8b1a31e08226745d052dbfdacecf1799781..adab79bdbafda9d0f68889ae79729e597f3d57a2 100644

--- a/test/cctest/test-heap.cc

+++ b/test/cctest/test-heap.cc

@@ -2429,7 +2429,11 @@ void ReleaseStackTraceDataTest(const char* source) {

CHECK(!resource->IsDisposed());

}

HEAP->CollectAllAvailableGarbage();

+ // External source is being retained by the stack trace.

+ CHECK(!resource->IsDisposed());

+ CompileRun("error.stack;");

+ HEAP->CollectAllAvailableGarbage();

// External source has been released.

CHECK(resource->IsDisposed());

delete resource;

« no previous file with comments | « test/cctest/test-decls.cc ('k') | test/message/overwritten-builtins.out » ('j') | no next file with comments »