Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5348)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_garbage_collector_factory.h

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc ('K') | « chrome/browser/extensions/extension_action_test_util.cc ('k') | chrome/browser/extensions/extension_garbage_collector_factory.cc » ('j') | chrome/browser/extensions/menu_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_garbage_collector_factory.h
diff --git a/chrome/browser/extensions/extension_garbage_collector_factory.h b/chrome/browser/extensions/extension_garbage_collector_factory.h
index 2f4f5d1499690781fd7e7446d6e3d5d41444811c..fd37e9e52d71945cccc1af1dc43b445ae44ee360 100644
--- a/chrome/browser/extensions/extension_garbage_collector_factory.h
+++ b/chrome/browser/extensions/extension_garbage_collector_factory.h
@@ -24,7 +24,8 @@ class ExtensionGarbageCollectorFactory
static ExtensionGarbageCollectorFactory* GetInstance();
- static KeyedService* BuildInstanceFor(content::BrowserContext* profile);
+ static scoped_ptr<KeyedService> BuildInstanceFor(
+ content::BrowserContext* profile);
Devlin 2015/06/08 19:29:43 nit: rename
Ilya Sherman 2015/06/08 22:11:43 Done.
private:
friend struct DefaultSingletonTraits<ExtensionGarbageCollectorFactory>;
« chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc ('K') | « chrome/browser/extensions/extension_action_test_util.cc ('k') | chrome/browser/extensions/extension_garbage_collector_factory.cc » ('j') | chrome/browser/extensions/menu_manager_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698