Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6027)

Unified Diff: chrome/browser/extensions/extension_garbage_collector_factory.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_garbage_collector_factory.cc
diff --git a/chrome/browser/extensions/extension_garbage_collector_factory.cc b/chrome/browser/extensions/extension_garbage_collector_factory.cc
index ea93370fab0ea568bdf47ed1490d4311a5430d04..debcaf0fb2462e13681859277d779d738d8cd46f 100644
--- a/chrome/browser/extensions/extension_garbage_collector_factory.cc
+++ b/chrome/browser/extensions/extension_garbage_collector_factory.cc
@@ -42,18 +42,18 @@ ExtensionGarbageCollectorFactory::ExtensionGarbageCollectorFactory()
ExtensionGarbageCollectorFactory::~ExtensionGarbageCollectorFactory() {}
// static
-KeyedService* ExtensionGarbageCollectorFactory::BuildInstanceFor(
+scoped_ptr<KeyedService> ExtensionGarbageCollectorFactory::BuildInstanceFor(
content::BrowserContext* context) {
#if defined(OS_CHROMEOS)
- return new ExtensionGarbageCollectorChromeOS(context);
+ return make_scoped_ptr(new ExtensionGarbageCollectorChromeOS(context));
#else
- return new ExtensionGarbageCollector(context);
+ return make_scoped_ptr(new ExtensionGarbageCollector(context));
#endif
}
KeyedService* ExtensionGarbageCollectorFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
- return BuildInstanceFor(context);
+ return BuildInstanceFor(context).release();
}
bool ExtensionGarbageCollectorFactory::ServiceIsCreatedWithBrowserContext()

Powered by Google App Engine
This is Rietveld 408576698