chrome/browser/extensions/menu_manager_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/menu_manager_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_garbage_collector_factory.h ('K') | « chrome/browser/extensions/menu_manager_factory.cc ('k') | chrome/browser/extensions/test_extension_system.h » ('j') | chrome/browser/invalidation/profile_invalidation_provider_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/menu_manager_unittest.cc

diff --git a/chrome/browser/extensions/menu_manager_unittest.cc b/chrome/browser/extensions/menu_manager_unittest.cc

index 8b1ec7d1f09427995dfcd880464e0861178005a2..710e14208b4868d1b9dfcb9d18771a681b651798 100644

--- a/chrome/browser/extensions/menu_manager_unittest.cc

+++ b/chrome/browser/extensions/menu_manager_unittest.cc

@@ -6,6 +6,7 @@

#include "base/files/scoped_temp_dir.h"

#include "base/json/json_reader.h"

+#include "base/memory/scoped_ptr.h"

#include "base/memory/scoped_vector.h"

#include "base/message_loop/message_loop.h"

#include "base/prefs/pref_service.h"

@@ -483,8 +484,9 @@ class MockEventRouter : public EventRouter {

};

// MockEventRouter factory function

-KeyedService* MockEventRouterFactoryFunction(content::BrowserContext* profile) {

- return new MockEventRouter(static_cast<Profile*>(profile));

+scoped_ptr<KeyedService> MockEventRouterFactoryFunction(

+ content::BrowserContext* profile) {

Devlin 2015/06/08 19:29:43 nit: rename

Ilya Sherman 2015/06/08 22:11:43 Done.

+ return make_scoped_ptr(new MockEventRouter(static_cast<Profile*>(profile)));

}

} // namespace