Issue 11636050: Eliminate ApiResourceEventNotifier.

Issue 11636050: Eliminate ApiResourceEventNotifier. (Closed)

Created:
8 years ago by miket_OOO

Modified:
7 years, 11 months ago

Reviewers:
asargent_no_longer_on_chrome, Ben Goodger (Google)

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Eliminate ApiResourceEventNotifier. This work fell out of a notification API change where I finally figured out that the EventNotifier wasn't the best way to send events back to the caller. We're now using a more standard Event scheme (which, in my defense, might not have existed back when AREN was conceived). Dead code eliminated. BUG=164249 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175905

Patch Set 1 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -236 lines)			Patch
M	chrome/browser/extensions/api/api_function.h	View	1 chunk	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/api/api_function.cc	View	2 chunks	+0 lines, -17 lines	0 comments	Download
M	chrome/browser/extensions/api/api_resource.h	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/api/api_resource.cc	View	1 chunk	+2 lines, -11 lines	0 comments	Download
D	chrome/browser/extensions/api/api_resource_event_notifier.h	View	1 chunk	+0 lines, -66 lines	0 comments	Download
D	chrome/browser/extensions/api/api_resource_event_notifier.cc	View	1 chunk	+0 lines, -82 lines	0 comments	Download
M	chrome/browser/extensions/api/api_resource_manager_unittest.cc	View	3 chunks	+4 lines, -17 lines	0 comments	Download
M	chrome/browser/extensions/api/serial/serial_connection.cc	View	3 chunks	+5 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/api/socket/socket.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/usb/usb_api.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/usb/usb_api.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/usb/usb_device_resource.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/usb/usb_device_resource.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/11636050/3001

7 years, 11 months ago (2013-01-09 19:04:18 UTC) #3

commit-bot: I haz the power

Presubmit check for 11636050-3001 failed and returned exit status 1. Running presubmit commit checks ...

7 years, 11 months ago (2013-01-09 19:04:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/11636050/3001

7 years, 11 months ago (2013-01-09 19:09:55 UTC) #6

Message was sent while issue was closed.

Change committed as 175905

Expand Messages | Collapse Messages