Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3904)

Unified Diff: chrome/browser/extensions/api/api_resource.h

Issue 11636050: Eliminate ApiResourceEventNotifier. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/api_function.cc ('k') | chrome/browser/extensions/api/api_resource.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/api_resource.h
diff --git a/chrome/browser/extensions/api/api_resource.h b/chrome/browser/extensions/api/api_resource.h
index 0507377ac64bd432303885d980b96f63670d616f..13361dc6cf5754c045726e4c95e2719ecd8e478f 100644
--- a/chrome/browser/extensions/api/api_resource.h
+++ b/chrome/browser/extensions/api/api_resource.h
@@ -11,8 +11,6 @@
namespace extensions {
-class ApiResourceEventNotifier;
-
// An ApiResource represents something that an extension API manages, such as a
// socket or a serial-port connection. Typically, an ApiResourceManager will
// control the lifetime of all ApiResources of a specific derived type.
@@ -25,20 +23,12 @@ class ApiResource {
}
protected:
- ApiResource(const std::string& owner_extension_id,
- ApiResourceEventNotifier* event_notifier);
+ explicit ApiResource(const std::string& owner_extension_id);
private:
- // The extension that owns this resource. This could be derived from
- // event_notifier, but that's a little too cute; to make future code
- // maintenance easier, we'll require callers to explicitly specify the owner,
- // and for now we'll assert that the owner implied by the event_notifier is
- // consistent with the explicit one.
+ // The extension that owns this resource.
const std::string& owner_extension_id_;
- // The object that lets this resource report events to the owner application.
- scoped_refptr<ApiResourceEventNotifier> event_notifier_;
-
DISALLOW_COPY_AND_ASSIGN(ApiResource);
};
« no previous file with comments | « chrome/browser/extensions/api/api_function.cc ('k') | chrome/browser/extensions/api/api_resource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698