Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Side by Side Diff: chrome/browser/extensions/api/api_resource_manager_unittest.cc

Issue 11636050: Eliminate ApiResourceEventNotifier. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_path.h" 5 #include "base/file_path.h"
6 #include "base/string_util.h" 6 #include "base/string_util.h"
7 #include "chrome/browser/extensions/api/api_resource.h" 7 #include "chrome/browser/extensions/api/api_resource.h"
8 #include "chrome/browser/extensions/api/api_resource_manager.h" 8 #include "chrome/browser/extensions/api/api_resource_manager.h"
9 #include "chrome/browser/extensions/extension_function_test_utils.h" 9 #include "chrome/browser/extensions/extension_function_test_utils.h"
10 #include "chrome/common/extensions/extension.h" 10 #include "chrome/common/extensions/extension.h"
11 #include "chrome/common/extensions/extension_test_util.h" 11 #include "chrome/common/extensions/extension_test_util.h"
12 #include "chrome/test/base/browser_with_test_window_test.h" 12 #include "chrome/test/base/browser_with_test_window_test.h"
13 #include "content/public/browser/browser_thread.h" 13 #include "content/public/browser/browser_thread.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 #include "chrome/browser/extensions/api/api_resource_event_notifier.h"
16 #include "chrome/browser/profiles/profile.h" 15 #include "chrome/browser/profiles/profile.h"
17 #include "googleurl/src/gurl.h" 16 #include "googleurl/src/gurl.h"
18 17
19 namespace utils = extension_function_test_utils; 18 namespace utils = extension_function_test_utils;
20 19
21 using content::BrowserThread; 20 using content::BrowserThread;
22 21
23 namespace extensions { 22 namespace extensions {
24 23
25 class ApiResourceManagerUnitTest : public BrowserWithTestWindowTest { 24 class ApiResourceManagerUnitTest : public BrowserWithTestWindowTest {
26 public: 25 public:
27 virtual void SetUp() { 26 virtual void SetUp() {
28 BrowserWithTestWindowTest::SetUp(); 27 BrowserWithTestWindowTest::SetUp();
29 } 28 }
30 }; 29 };
31 30
32 class FakeApiResource : public ApiResource { 31 class FakeApiResource : public ApiResource {
33 public: 32 public:
34 FakeApiResource(const std::string& owner_extension_id, 33 FakeApiResource(const std::string& owner_extension_id) :
35 ApiResourceEventNotifier* event_notifier) : 34 ApiResource(owner_extension_id) {}
36 ApiResource(owner_extension_id, event_notifier) {}
37 ~FakeApiResource() {} 35 ~FakeApiResource() {}
38 }; 36 };
39 37
40 TEST_F(ApiResourceManagerUnitTest, TwoAppsCannotShareResources) { 38 TEST_F(ApiResourceManagerUnitTest, TwoAppsCannotShareResources) {
41 scoped_ptr<ApiResourceManager<FakeApiResource> > manager( 39 scoped_ptr<ApiResourceManager<FakeApiResource> > manager(
42 new ApiResourceManager<FakeApiResource>(BrowserThread::UI)); 40 new ApiResourceManager<FakeApiResource>(BrowserThread::UI));
43 scoped_refptr<extensions::Extension> extension_one( 41 scoped_refptr<extensions::Extension> extension_one(
44 utils::CreateEmptyExtension("one")); 42 utils::CreateEmptyExtension("one"));
45 scoped_refptr<extensions::Extension> extension_two( 43 scoped_refptr<extensions::Extension> extension_two(
46 utils::CreateEmptyExtension("two")); 44 utils::CreateEmptyExtension("two"));
47 45
48 const std::string extension_one_id(extension_one->id()); 46 const std::string extension_one_id(extension_one->id());
49 const std::string extension_two_id(extension_two->id()); 47 const std::string extension_two_id(extension_two->id());
50 48
51 GURL url_one("url-one"); 49 int resource_one_id = manager->Add(new FakeApiResource(extension_one_id));
52 GURL url_two("url-two"); 50 int resource_two_id = manager->Add(new FakeApiResource(extension_two_id));
53 scoped_refptr<ApiResourceEventNotifier> event_notifier_one(
54 new ApiResourceEventNotifier(
55 NULL, NULL, extension_one_id, 1111, url_one));
56 scoped_refptr<ApiResourceEventNotifier> event_notifier_two(
57 new ApiResourceEventNotifier(
58 NULL, NULL, extension_two_id, 2222, url_two));
59
60 int resource_one_id = manager->Add(new FakeApiResource(
61 extension_one_id, event_notifier_one.get()));
62 int resource_two_id = manager->Add(new FakeApiResource(
63 extension_two_id, event_notifier_two.get()));
64 CHECK(resource_one_id); 51 CHECK(resource_one_id);
65 CHECK(resource_two_id); 52 CHECK(resource_two_id);
66 53
67 // Confirm each extension can get its own resource. 54 // Confirm each extension can get its own resource.
68 ASSERT_TRUE(manager->Get(extension_one_id, resource_one_id) != NULL); 55 ASSERT_TRUE(manager->Get(extension_one_id, resource_one_id) != NULL);
69 ASSERT_TRUE(manager->Get(extension_two_id, resource_two_id) != NULL); 56 ASSERT_TRUE(manager->Get(extension_two_id, resource_two_id) != NULL);
70 57
71 // Confirm neither extension can get the other's resource. 58 // Confirm neither extension can get the other's resource.
72 ASSERT_TRUE(manager->Get(extension_one_id, resource_two_id) == NULL); 59 ASSERT_TRUE(manager->Get(extension_one_id, resource_two_id) == NULL);
73 ASSERT_TRUE(manager->Get(extension_two_id, resource_one_id) == NULL); 60 ASSERT_TRUE(manager->Get(extension_two_id, resource_one_id) == NULL);
74 61
75 // And make sure we're not susceptible to any Jedi mind tricks. 62 // And make sure we're not susceptible to any Jedi mind tricks.
76 ASSERT_TRUE(manager->Get(std::string(), resource_one_id) == NULL); 63 ASSERT_TRUE(manager->Get(std::string(), resource_one_id) == NULL);
77 } 64 }
78 65
79 } // namespace extensions 66 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698