chrome/browser/autofill/autofill_external_delegate.h - Issue 11636040: AutofillPopupController clarifications + simplifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_external_delegate.h

Issue 11636040: AutofillPopupController clarifications + simplifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: relative patchset Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autofill/autofill_external_delegate.h

diff --git a/chrome/browser/autofill/autofill_external_delegate.h b/chrome/browser/autofill/autofill_external_delegate.h

index 04dd109b547c8fdc2b74eb7ea6af126031167afc..258d8a41999592ad0c283708bb913d4e17afbbe3 100644

--- a/chrome/browser/autofill/autofill_external_delegate.h

+++ b/chrome/browser/autofill/autofill_external_delegate.h

@@ -48,9 +48,8 @@ class AutofillExternalDelegate

// AutofillPopupDelegate implementation.

virtual void SelectAutofillSuggestion(int unique_id) OVERRIDE;

- virtual bool DidAcceptAutofillSuggestion(const string16& value,

- int unique_id,

- unsigned index) OVERRIDE;

+ virtual void DidAcceptAutofillSuggestion(const string16& value,

+ int unique_id) OVERRIDE;

Ilya Sherman 2012/12/20 04:34:52 nit: Should we drop "Autofill" from these method n

Evan Stade 2012/12/20 20:01:25 Done.

virtual void ClearPreviewedForm() OVERRIDE;

virtual void RemoveAutocompleteEntry(const string16& value) OVERRIDE;

virtual void RemoveAutofillProfileOrCreditCard(int unique_id) OVERRIDE;