AutofillPopupController clarifications + simplifications.

chrome/browser/autofill/autofill_external_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
 
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ skipping 30 matching lines @@
       public AutofillPopupDelegate {
  public:
   // Creates an AutofillExternalDelegate and attaches it to the specified
   // contents; the second argument is an AutofillManager managing Autofill for
   // that WebContents.
   static void CreateForWebContentsAndManager(content::WebContents* web_contents,
                                              AutofillManager* autofill_manager);
 
   // AutofillPopupDelegate implementation.
   virtual void SelectAutofillSuggestion(int unique_id) OVERRIDE;
-  virtual bool DidAcceptAutofillSuggestion(const string16& value,
-                                           int unique_id,
-                                           unsigned index) OVERRIDE;
+  virtual void DidAcceptAutofillSuggestion(const string16& value,
+                                           int unique_id) OVERRIDE;

[Ilya Sherman, 2012/12/20 04:34:52]

nit: Should we drop "Autofill" from these method names?

[Evan Stade, 2012/12/20 20:01:25]

Done.

   virtual void ClearPreviewedForm() OVERRIDE;
   virtual void RemoveAutocompleteEntry(const string16& value) OVERRIDE;
   virtual void RemoveAutofillProfileOrCreditCard(int unique_id) OVERRIDE;
   virtual void ControllerDestroyed() OVERRIDE;
 
   // Records and associates a query_id with web form data.  Called
   // when the renderer posts an Autofill query to the browser. |bounds|
   // is window relative. |display_warning_if_disabled| tells us if we should
   // display warnings (such as autofill is disabled, but had suggestions).
   // We might not want to display the warning if a website has disabled
@@ skipping 125 matching lines @@
   // The current data list values.
   std::vector<string16> data_list_values_;
   std::vector<string16> data_list_labels_;
   std::vector<string16> data_list_icons_;
   std::vector<int> data_list_unique_ids_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_