Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chrome/browser/autofill/autofill_external_delegate.cc

Issue 11636040: AutofillPopupController clarifications + simplifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: relative patchset Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_external_delegate.cc
diff --git a/chrome/browser/autofill/autofill_external_delegate.cc b/chrome/browser/autofill/autofill_external_delegate.cc
index c58ff06f4634fa71c58143a13a12b06eb253064e..155089492edb4dc407793b09805637a88e95917d 100644
--- a/chrome/browser/autofill/autofill_external_delegate.cc
+++ b/chrome/browser/autofill/autofill_external_delegate.cc
@@ -223,14 +223,9 @@ void AutofillExternalDelegate::DidEndTextFieldEditing() {
has_shown_autofill_popup_for_current_edit_ = false;
}
-bool AutofillExternalDelegate::DidAcceptAutofillSuggestion(
+void AutofillExternalDelegate::DidAcceptAutofillSuggestion(
const string16& value,
- int unique_id,
- unsigned index) {
- // If the selected element is a warning we don't want to do anything.
- if (unique_id == WebAutofillClient::MenuItemIDWarningMessage)
- return false;
-
+ int unique_id) {
RenderViewHost* host = web_contents_->GetRenderViewHost();
if (unique_id == WebAutofillClient::MenuItemIDAutofillOptions) {
@@ -257,8 +252,6 @@ bool AutofillExternalDelegate::DidAcceptAutofillSuggestion(
}
HideAutofillPopup();
-
- return true;
}
void AutofillExternalDelegate::ClearPreviewedForm() {

Powered by Google App Engine
This is Rietveld 408576698