Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: remoting/host/disconnect_window_gtk.cc

Issue 11583023: Give DisconnectWindow some TLC. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replace DisconnectCallback with base::Closure Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/disconnect_window.h ('k') | remoting/host/disconnect_window_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/disconnect_window_gtk.cc
diff --git a/remoting/host/disconnect_window_gtk.cc b/remoting/host/disconnect_window_gtk.cc
index 3a58d35e25827ced91c3f2d2e4256afeb51d92bc..4f818b1d9fcbde32e50a10d22099f8c82a728367 100644
--- a/remoting/host/disconnect_window_gtk.cc
+++ b/remoting/host/disconnect_window_gtk.cc
@@ -22,7 +22,7 @@ class DisconnectWindowGtk : public DisconnectWindow {
virtual ~DisconnectWindowGtk();
virtual bool Show(const UiStrings& ui_strings,
- const DisconnectCallback& disconnect_callback,
+ const base::Closure& disconnect_callback,
const std::string& username) OVERRIDE;
virtual void Hide() OVERRIDE;
@@ -36,7 +36,7 @@ class DisconnectWindowGtk : public DisconnectWindow {
void CreateWindow(const UiStrings& ui_strings);
- DisconnectCallback disconnect_callback_;
+ base::Closure disconnect_callback_;
GtkWidget* disconnect_window_;
GtkWidget* message_;
GtkWidget* button_;
@@ -56,6 +56,7 @@ DisconnectWindowGtk::DisconnectWindowGtk()
}
DisconnectWindowGtk::~DisconnectWindowGtk() {
+ Hide();
}
void DisconnectWindowGtk::CreateWindow(const UiStrings& ui_strings) {
@@ -129,7 +130,7 @@ void DisconnectWindowGtk::CreateWindow(const UiStrings& ui_strings) {
}
bool DisconnectWindowGtk::Show(const UiStrings& ui_strings,
- const DisconnectCallback& disconnect_callback,
+ const base::Closure& disconnect_callback,
const std::string& username) {
DCHECK(disconnect_callback_.is_null());
DCHECK(!disconnect_callback.is_null());
« no previous file with comments | « remoting/host/disconnect_window.h ('k') | remoting/host/disconnect_window_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698