Give DisconnectWindow some TLC.

Give DisconnectWindow some TLC.

- Update the DisconnectWindow interface specification to clarify corner cases.
- Update the DisconnectCallback semantics to match the DisconnectWindow interface spec.
  - In particular, don't invoke the DisconnectCallback on Hide() or deletion.
- On Windows, invoke the DisconnectCallback if WM_DESTROY is unexpectedly received.

BUG=166056, 166514
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173892

[Wez, 2012-12-18 23:01:32]

PTAL

[Jamie, 2012-12-19 00:11:50]

LGTM once my comment is addressed. If switching to base::Closure involves lots
of changes elsewhere, it can be a separate CL, assuming you think it's
worthwhile.

https://chromiumcodereview.appspot.com/11583023/diff/1/remoting/host/disconne...
File remoting/host/disconnect_window.h (right):

https://chromiumcodereview.appspot.com/11583023/diff/1/remoting/host/disconne...
remoting/host/disconnect_window.h:24: // or presses the Disconnect hot-key
sequence.
Clarify that it will also be called if the user manages to hide the window via
some other nefarious means. Or, since that's covered below, make this comment
more general, or omit it entirely; perhaps even get rid of the typedef and use
base::Closure.

[Wez, 2012-12-19 00:26:06]

https://chromiumcodereview.appspot.com/11583023/diff/1/remoting/host/disconne...
File remoting/host/disconnect_window.h (right):

https://chromiumcodereview.appspot.com/11583023/diff/1/remoting/host/disconne...
remoting/host/disconnect_window.h:24: // or presses the Disconnect hot-key
sequence.
On 2012/12/19 00:11:50, Jamie wrote:
> Clarify that it will also be called if the user manages to hide the window via
> some other nefarious means. Or, since that's covered below, make this comment
> more general, or omit it entirely; perhaps even get rid of the typedef and use
> base::Closure.

Done.

[commit-bot: I haz the power, 2012-12-19 00:26:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/11583023/5001

[commit-bot: I haz the power, 2012-12-19 02:54:50]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2012-12-19 03:05:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/11583023/5001

[commit-bot: I haz the power, 2012-12-19 10:30:54]

Change committed as 173892