Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: remoting/host/disconnect_window.h

Issue 11583023: Give DisconnectWindow some TLC. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replace DisconnectCallback with base::Closure Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/host/disconnect_window_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/disconnect_window.h
diff --git a/remoting/host/disconnect_window.h b/remoting/host/disconnect_window.h
index 51269b77fb47fea5c6bf2057d692a548a89df614..1bc053bba099046c19e6cb7944f93fd4cb59a945 100644
--- a/remoting/host/disconnect_window.h
+++ b/remoting/host/disconnect_window.h
@@ -20,20 +20,17 @@ class DisconnectWindow {
kMaximumConnectedNameWidthInPixels = 400
};
- // DisconnectCallback is called when the user clicks on the Disconnect button
- // to disconnect the session. This callback is provided as a parameter to the
- // Show() method, and will be triggered on the UI thread.
- typedef base::Callback<void(void)> DisconnectCallback;
-
virtual ~DisconnectWindow() {}
- // Shows the disconnect window allowing the user to disconnect the session.
- // Returns false if the window could not be shown for any reason. The
- // disconnect callback will be invoked if the user clicks the disconnect
- // button, or if the window is closed for any reason other than Hide() being
- // called
+ // Shows the disconnect window, allowing the user to disconnect the session.
+ // The window will display text from |ui_strings| and |username|.
+ // |disconnect_callback| will be invoked on the calling UI thread when the
+ // user chooses to disconnect, or if the window is closed by any means other
+ // than Hide(), or deletion of the DisconnectWindow instance.
+ // Show returns false if the window cannot be shown, in which case the
+ // callback will not be invoked.
virtual bool Show(const UiStrings& ui_strings,
- const DisconnectCallback& disconnect_callback,
+ const base::Closure& disconnect_callback,
const std::string& username) = 0;
// Hides the disconnect window. The disconnect callback will not be invoked.
« no previous file with comments | « no previous file | remoting/host/disconnect_window_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698