Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 11564027: Enable virtual context on IMG devices in a different way (Closed)

Created:
8 years ago by no sievers
Modified:
8 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, klobag.chromium
Visibility:
Public.

Description

Enable virtual context on IMG devices in a different way Revert "Enable virtual context on IMG devices only." > Review URL: https://chromiumcodereview.appspot.com/11555010 The flags are only initialized *after* we create the context and init the decoder (needs a current context for glGetString()). Instead, append the commandline from gpu_info_collector_android.cc. BUG=160710, 165531 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173245

Patch Set 1 #

Patch Set 2 : leave is_qualcomm #

Patch Set 3 : add t604 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/gpu/gpu_info_collector_android.cc View 1 2 2 chunks +19 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 5 chunks +5 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
no sievers
ptal
8 years ago (2012-12-14 02:00:25 UTC) #1
aelias_OOO_until_Jul13
Please leave is_qualcomm as https://codereview.chromium.org/11574023/ depends on it.
8 years ago (2012-12-14 02:27:13 UTC) #2
no sievers
On 2012/12/14 02:27:13, aelias wrote: > Please leave is_qualcomm as https://codereview.chromium.org/11574023/ depends on > it. ...
8 years ago (2012-12-14 04:00:13 UTC) #3
aelias_OOO_until_Jul13
lgtm
8 years ago (2012-12-14 04:01:33 UTC) #4
klobag.chromium
Please also enable to ARM devices as canvas2D depends on this.
8 years ago (2012-12-14 17:50:15 UTC) #5
apatrick_chromium
lgtm
8 years ago (2012-12-14 19:03:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/11564027/4001
8 years ago (2012-12-14 19:55:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/11564027/5005
8 years ago (2012-12-14 23:36:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/11564027/5005
8 years ago (2012-12-15 00:39:17 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-15 00:41:29 UTC) #10
Message was sent while issue was closed.
Change committed as 173245

Powered by Google App Engine
This is Rietveld 408576698