Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 11555010: Enable virtual context on IMG devices only. (Closed)

Created:
8 years ago by aelias_OOO_until_Jul13
Modified:
8 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, klobag.chromium, greggman, piman, jamesr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable virtual context on IMG devices only. This adds booleans to feature_info for all the common Android vendors and turns on virtual contexts for IMG only, as there are remaining bugs with the other architectures (and IMG is the main reason we are working on virtual contexts to begin with). Setting the command-line flag will force-enable virtual contexts on any architecture. BUG=160710, 165531 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 5 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
aelias_OOO_until_Jul13
Hi Alastair, We figured we should turn it on for IMG only as we work ...
8 years ago (2012-12-12 02:52:36 UTC) #1
apatrick_chromium
lgtm
8 years ago (2012-12-12 02:58:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/11555010/1
8 years ago (2012-12-12 03:03:17 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years ago (2012-12-12 03:14:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/11555010/1
8 years ago (2012-12-12 04:16:41 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-12 05:31:03 UTC) #6
Message was sent while issue was closed.
Change committed as 172535

Powered by Google App Engine
This is Rietveld 408576698