Issue 1155113002: Oilpan: HeapObjectHeader::checkHeader should not allow access on orphaned pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1155113002: Oilpan: HeapObjectHeader::checkHeader should not allow access on orphaned pages (Closed)

Created:
5 years, 7 months ago by haraken

Modified:
5 years, 7 months ago

Reviewers:
oilpan-reviews, keishi

CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: HeapObjectHeader::checkHeader should not allow access on orphaned pages This CL forbids access on headers in orphaned pages, since it mustn't happen. Also this CL adds a couple of header->checkHeader() to harden verifications in the code base. BUG=475801 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195889

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -1 line)			Patch
M	Source/platform/heap/Heap.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/platform/heap/Heap.cpp	View	5 chunks	+5 lines, -0 lines	0 comments	Download
M	Source/platform/heap/HeapAllocator.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/platform/heap/TraceTraits.h	View	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155113002/1

5 years, 7 months ago (2015-05-26 03:27:56 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-26 05:37:48 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195889

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages